Commit aea00a6c authored by Devendra Naga's avatar Devendra Naga Committed by Linus Torvalds

drivers/video/backlight/lm3639_bl.c: remove ret = -EIO at error paths of probe

The APIs are returning correctly the err codes, no need to assign -EIO
to the ret again.
Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Acked-by: default avatarDaniel Jeong <daniel.jeong@ti.com>
Cc: G.Shark Jeong <gshark.jeong@gmail.com>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 47cf076b
...@@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client, ...@@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client,
&lm3639_bled_ops, &props); &lm3639_bled_ops, &props);
if (IS_ERR(pchip->bled)) { if (IS_ERR(pchip->bled)) {
dev_err(&client->dev, "fail : backlight register\n"); dev_err(&client->dev, "fail : backlight register\n");
ret = -EIO; ret = PTR_ERR(pchip->bled);
goto err_out; goto err_out;
} }
ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode); ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode);
if (ret < 0) { if (ret < 0) {
dev_err(&client->dev, "failed : add sysfs entries\n"); dev_err(&client->dev, "failed : add sysfs entries\n");
ret = -EIO;
goto err_bled_mode; goto err_bled_mode;
} }
...@@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client, ...@@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client,
&client->dev, &pchip->cdev_flash); &client->dev, &pchip->cdev_flash);
if (ret < 0) { if (ret < 0) {
dev_err(&client->dev, "fail : flash register\n"); dev_err(&client->dev, "fail : flash register\n");
ret = -EIO;
goto err_flash; goto err_flash;
} }
...@@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client, ...@@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client,
&client->dev, &pchip->cdev_torch); &client->dev, &pchip->cdev_torch);
if (ret < 0) { if (ret < 0) {
dev_err(&client->dev, "fail : torch register\n"); dev_err(&client->dev, "fail : torch register\n");
ret = -EIO;
goto err_torch; goto err_torch;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment