Commit aef79d82 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Linus Torvalds

spi_mpc83xx: remove dead code

This patch removes #if 0'ed code, and spi_mpc83xx->busy variable that is
used by that dead snippet only.
Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: David Brownell <david-b@pacbell.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b9b9af11
...@@ -98,8 +98,6 @@ struct mpc83xx_spi { ...@@ -98,8 +98,6 @@ struct mpc83xx_spi {
bool qe_mode; bool qe_mode;
u8 busy;
struct workqueue_struct *workqueue; struct workqueue_struct *workqueue;
struct work_struct work; struct work_struct work;
...@@ -411,7 +409,6 @@ static void mpc83xx_spi_work(struct work_struct *work) ...@@ -411,7 +409,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
work); work);
spin_lock_irq(&mpc83xx_spi->lock); spin_lock_irq(&mpc83xx_spi->lock);
mpc83xx_spi->busy = 1;
while (!list_empty(&mpc83xx_spi->queue)) { while (!list_empty(&mpc83xx_spi->queue)) {
struct spi_message *m = container_of(mpc83xx_spi->queue.next, struct spi_message *m = container_of(mpc83xx_spi->queue.next,
struct spi_message, queue); struct spi_message, queue);
...@@ -423,7 +420,6 @@ static void mpc83xx_spi_work(struct work_struct *work) ...@@ -423,7 +420,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
spin_lock_irq(&mpc83xx_spi->lock); spin_lock_irq(&mpc83xx_spi->lock);
} }
mpc83xx_spi->busy = 0;
spin_unlock_irq(&mpc83xx_spi->lock); spin_unlock_irq(&mpc83xx_spi->lock);
} }
...@@ -465,19 +461,6 @@ static int mpc83xx_spi_setup(struct spi_device *spi) ...@@ -465,19 +461,6 @@ static int mpc83xx_spi_setup(struct spi_device *spi)
cs->hw_mode = hw_mode; /* Restore settings */ cs->hw_mode = hw_mode; /* Restore settings */
return retval; return retval;
} }
#if 0 /* Don't think this is needed */
/* NOTE we _need_ to call chipselect() early, ideally with adapter
* setup, unless the hardware defaults cooperate to avoid confusion
* between normal (active low) and inverted chipselects.
*/
/* deselect chip (low or high) */
spin_lock(&mpc83xx_spi->lock);
if (!mpc83xx_spi->busy)
mpc83xx_spi_chipselect(spi, BITBANG_CS_INACTIVE);
spin_unlock(&mpc83xx_spi->lock);
#endif
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment