Commit b10178ee authored by Stanley Chu's avatar Stanley Chu Committed by Martin K. Petersen

scsi: ufs: Clean up completed request without interrupt notification

If somehow no interrupt notification is raised for a completed request and
its doorbell bit is cleared by host, UFS driver needs to cleanup its
outstanding bit in ufshcd_abort(). Otherwise, system may behave abnormally
in the following scenario:

After ufshcd_abort() returns, this request will be requeued by SCSI layer
with its outstanding bit set. Any future completed request will trigger
ufshcd_transfer_req_compl() to handle all "completed outstanding bits". At
this time the "abnormal outstanding bit" will be detected and the "requeued
request" will be chosen to execute request post-processing flow. This is
wrong because this request is still "alive".

Link: https://lore.kernel.org/r/20200811141859.27399-2-huobean@gmail.comReviewed-by: default avatarCan Guo <cang@codeaurora.org>
Acked-by: default avatarAvri Altman <avri.altman@wdc.com>
Signed-off-by: default avatarStanley Chu <stanley.chu@mediatek.com>
Signed-off-by: default avatarBean Huo <beanhuo@micron.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 127d5f7c
...@@ -6495,7 +6495,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) ...@@ -6495,7 +6495,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
/* command completed already */ /* command completed already */
dev_err(hba->dev, "%s: cmd at tag %d successfully cleared from DB.\n", dev_err(hba->dev, "%s: cmd at tag %d successfully cleared from DB.\n",
__func__, tag); __func__, tag);
goto out; goto cleanup;
} else { } else {
dev_err(hba->dev, dev_err(hba->dev,
"%s: no response from device. tag = %d, err %d\n", "%s: no response from device. tag = %d, err %d\n",
...@@ -6529,6 +6529,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) ...@@ -6529,6 +6529,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
goto out; goto out;
} }
cleanup:
scsi_dma_unmap(cmd); scsi_dma_unmap(cmd);
spin_lock_irqsave(host->host_lock, flags); spin_lock_irqsave(host->host_lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment