Commit b14c369d authored by Stefan Richter's avatar Stefan Richter

firewire: ohci: add a comment on PHY reg access serialization

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 9ef28ccd
...@@ -513,6 +513,12 @@ static inline void flush_writes(const struct fw_ohci *ohci) ...@@ -513,6 +513,12 @@ static inline void flush_writes(const struct fw_ohci *ohci)
reg_read(ohci, OHCI1394_Version); reg_read(ohci, OHCI1394_Version);
} }
/*
* Beware! read_phy_reg(), write_phy_reg(), update_phy_reg(), and
* read_paged_phy_reg() require the caller to hold ohci->phy_reg_mutex.
* In other words, only use ohci_read_phy_reg() and ohci_update_phy_reg()
* directly. Exceptions are intrinsically serialized contexts like pci_probe.
*/
static int read_phy_reg(struct fw_ohci *ohci, int addr) static int read_phy_reg(struct fw_ohci *ohci, int addr)
{ {
u32 val; u32 val;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment