Commit b295e5c7 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] usbvision: cleanup the code

There's a dead code on usbvision that makes it harder to read
and produces a smatch warning about bad identation.

Improve the code readability and add a FIXME to warn about
the current hack there.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 6b20cf3c
...@@ -1061,13 +1061,24 @@ static ssize_t usbvision_read(struct file *file, char __user *buf, ...@@ -1061,13 +1061,24 @@ static ssize_t usbvision_read(struct file *file, char __user *buf,
__func__, __func__,
(unsigned long)count, frame->bytes_read); (unsigned long)count, frame->bytes_read);
/* For now, forget the frame if it has not been read in one shot. */ #if 1
/* if (frame->bytes_read >= frame->scanlength) {*/ /* All data has been read */ /*
* FIXME:
* For now, forget the frame if it has not been read in one shot.
*/
frame->bytes_read = 0;
/* Mark it as available to be used again. */
frame->grabstate = frame_state_unused;
#else
if (frame->bytes_read >= frame->scanlength) {
/* All data has been read */
frame->bytes_read = 0; frame->bytes_read = 0;
/* Mark it as available to be used again. */ /* Mark it as available to be used again. */
frame->grabstate = frame_state_unused; frame->grabstate = frame_state_unused;
/* } */ }
#endif
return count; return count;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment