Commit b4e955e9 authored by Taehee Yoo's avatar Taehee Yoo Committed by Pablo Neira Ayuso

netfilter: xt_hashlimit: fix a possible memory leak in htable_create()

In the htable_create(), hinfo is allocated by vmalloc()
So that if error occurred, hinfo should be freed.

Fixes: 11d5f157 ("netfilter: xt_hashlimit: Create revision 2 to support higher pps rates")
Signed-off-by: default avatarTaehee Yoo <ap420073@gmail.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 29e38801
...@@ -295,9 +295,10 @@ static int htable_create(struct net *net, struct hashlimit_cfg3 *cfg, ...@@ -295,9 +295,10 @@ static int htable_create(struct net *net, struct hashlimit_cfg3 *cfg,
/* copy match config into hashtable config */ /* copy match config into hashtable config */
ret = cfg_copy(&hinfo->cfg, (void *)cfg, 3); ret = cfg_copy(&hinfo->cfg, (void *)cfg, 3);
if (ret) {
if (ret) vfree(hinfo);
return ret; return ret;
}
hinfo->cfg.size = size; hinfo->cfg.size = size;
if (hinfo->cfg.max == 0) if (hinfo->cfg.max == 0)
...@@ -814,7 +815,6 @@ hashlimit_mt_v1(const struct sk_buff *skb, struct xt_action_param *par) ...@@ -814,7 +815,6 @@ hashlimit_mt_v1(const struct sk_buff *skb, struct xt_action_param *par)
int ret; int ret;
ret = cfg_copy(&cfg, (void *)&info->cfg, 1); ret = cfg_copy(&cfg, (void *)&info->cfg, 1);
if (ret) if (ret)
return ret; return ret;
...@@ -830,7 +830,6 @@ hashlimit_mt_v2(const struct sk_buff *skb, struct xt_action_param *par) ...@@ -830,7 +830,6 @@ hashlimit_mt_v2(const struct sk_buff *skb, struct xt_action_param *par)
int ret; int ret;
ret = cfg_copy(&cfg, (void *)&info->cfg, 2); ret = cfg_copy(&cfg, (void *)&info->cfg, 2);
if (ret) if (ret)
return ret; return ret;
...@@ -921,7 +920,6 @@ static int hashlimit_mt_check_v1(const struct xt_mtchk_param *par) ...@@ -921,7 +920,6 @@ static int hashlimit_mt_check_v1(const struct xt_mtchk_param *par)
return ret; return ret;
ret = cfg_copy(&cfg, (void *)&info->cfg, 1); ret = cfg_copy(&cfg, (void *)&info->cfg, 1);
if (ret) if (ret)
return ret; return ret;
...@@ -940,7 +938,6 @@ static int hashlimit_mt_check_v2(const struct xt_mtchk_param *par) ...@@ -940,7 +938,6 @@ static int hashlimit_mt_check_v2(const struct xt_mtchk_param *par)
return ret; return ret;
ret = cfg_copy(&cfg, (void *)&info->cfg, 2); ret = cfg_copy(&cfg, (void *)&info->cfg, 2);
if (ret) if (ret)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment