Commit b5e319c2 authored by Peter Pregler's avatar Peter Pregler Committed by Linus Torvalds

[PATCH] cpia.c rmmod deadlock fix

Newer versions of module-init-tools do some locking now which leads to a
dead-lock if cpia.c does a request_module("cpia_usb/pp").  The attached
patch against 2.6.8 removes the request_module.  The problem is actually
the same as is documented in debian bug #259056 which was caused by alsa
autoloading some oss-modules.  So I guess there might be more places in the
kernel where this new locking in the module-init-tools might lead to
dead-locks.
Signed-off-by: default avatarPeter Pregler <Peter_Pregler@email.com>
Acked-by: default avatarGerd Knorr <kraxel@bytesex.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 5e2f1b20
...@@ -4047,22 +4047,13 @@ static int __init cpia_init(void) ...@@ -4047,22 +4047,13 @@ static int __init cpia_init(void)
proc_cpia_create(); proc_cpia_create();
#endif #endif
#ifdef CONFIG_KMOD
#ifdef CONFIG_VIDEO_CPIA_PP_MODULE
request_module("cpia_pp");
#endif
#ifdef CONFIG_VIDEO_CPIA_USB_MODULE
request_module("cpia_usb");
#endif
#endif /* CONFIG_KMOD */
#ifdef CONFIG_VIDEO_CPIA_PP #ifdef CONFIG_VIDEO_CPIA_PP
cpia_pp_init(); cpia_pp_init();
#endif #endif
#ifdef CONFIG_VIDEO_CPIA_USB #ifdef CONFIG_VIDEO_CPIA_USB
cpia_usb_init(); cpia_usb_init();
#endif #endif
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment