Commit b63f69d0 authored by Ed Spiridonov's avatar Ed Spiridonov Committed by Marc Kleine-Budde

can: mcp251x: add message about sucessful/unsuccessful probe

Silent ignorance of errors during probe procedure is a bad thing, this
patch fixes it. Extra message added for hardware initialization
failure. Such common issues are mostly caused by wrong wiring.  Message
about success added as well, it should be useful to debug new hardware
configuration, especially in case of several CAN buses.
Signed-off-by: default avatarEd Spiridonov <edo.rus@gmail.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 926f1035
...@@ -1145,8 +1145,11 @@ static int mcp251x_can_probe(struct spi_device *spi) ...@@ -1145,8 +1145,11 @@ static int mcp251x_can_probe(struct spi_device *spi)
/* Here is OK to not lock the MCP, no one knows about it yet */ /* Here is OK to not lock the MCP, no one knows about it yet */
ret = mcp251x_hw_probe(spi); ret = mcp251x_hw_probe(spi);
if (ret) if (ret) {
if (ret == -ENODEV)
dev_err(&spi->dev, "Cannot initialize MCP%x. Wrong wiring?\n", priv->model);
goto error_probe; goto error_probe;
}
mcp251x_hw_sleep(spi); mcp251x_hw_sleep(spi);
...@@ -1156,6 +1159,7 @@ static int mcp251x_can_probe(struct spi_device *spi) ...@@ -1156,6 +1159,7 @@ static int mcp251x_can_probe(struct spi_device *spi)
devm_can_led_init(net); devm_can_led_init(net);
netdev_info(net, "MCP%x successfully initialized.\n", priv->model);
return 0; return 0;
error_probe: error_probe:
...@@ -1168,6 +1172,7 @@ static int mcp251x_can_probe(struct spi_device *spi) ...@@ -1168,6 +1172,7 @@ static int mcp251x_can_probe(struct spi_device *spi)
out_free: out_free:
free_candev(net); free_candev(net);
dev_err(&spi->dev, "Probe failed, err=%d\n", -ret);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment