Commit b6559c8c authored by Paul Cercueil's avatar Paul Cercueil Committed by James Hogan

watchdog: JZ4740: Drop module remove function

When the watchdog was configured for nowayout, and after the
userspace watchdog daemon closed the dev node without sending the
magic character, unloading this module stopped the watchdog
hardware, which was clearly a problem.

Besides, unloading the module is not possible when the userspace
watchdog daemon is running, so it's safe to assume that we don't
need to stop the watchdog hardware in the jz4740_wdt_remove()
function.

For this reason, the jz4740_wdt_remove() function can then be
dropped alltogether.
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Mathieu Malaterre <malat@debian.org>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-mips@linux-mips.org
Signed-off-by: default avatarJames Hogan <jhogan@kernel.org>
parent b4918057
...@@ -206,16 +206,8 @@ static int jz4740_wdt_probe(struct platform_device *pdev) ...@@ -206,16 +206,8 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int jz4740_wdt_remove(struct platform_device *pdev)
{
struct jz4740_wdt_drvdata *drvdata = platform_get_drvdata(pdev);
return jz4740_wdt_stop(&drvdata->wdt);
}
static struct platform_driver jz4740_wdt_driver = { static struct platform_driver jz4740_wdt_driver = {
.probe = jz4740_wdt_probe, .probe = jz4740_wdt_probe,
.remove = jz4740_wdt_remove,
.driver = { .driver = {
.name = "jz4740-wdt", .name = "jz4740-wdt",
.of_match_table = of_match_ptr(jz4740_wdt_of_matches), .of_match_table = of_match_ptr(jz4740_wdt_of_matches),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment