Commit b8215dce authored by Jakub Sitnicki's avatar Jakub Sitnicki Committed by Alexei Starovoitov

selftests/bpf, flow_dissector: Close TAP device FD after the test

test_flow_dissector leaves a TAP device after it's finished, potentially
interfering with other tests that will run after it. Fix it by closing the
TAP descriptor on cleanup.

Fixes: 0905beec ("selftests/bpf: run flow dissector tests in skb-less mode")
Signed-off-by: default avatarJakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200531082846.2117903-11-jakub@cloudflare.com
parent 1f043f87
...@@ -524,6 +524,7 @@ void test_flow_dissector(void) ...@@ -524,6 +524,7 @@ void test_flow_dissector(void)
CHECK_ATTR(err, tests[i].name, "bpf_map_delete_elem %d\n", err); CHECK_ATTR(err, tests[i].name, "bpf_map_delete_elem %d\n", err);
} }
close(tap_fd);
bpf_prog_detach(prog_fd, BPF_FLOW_DISSECTOR); bpf_prog_detach(prog_fd, BPF_FLOW_DISSECTOR);
bpf_object__close(obj); bpf_object__close(obj);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment