Commit b9eb3b14 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen

scsi: aacraid: fix a signedness bug

The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.

[mkp: fixed typo]

Fixes: 0d643ff3 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d772a65d
...@@ -1346,7 +1346,7 @@ struct fib { ...@@ -1346,7 +1346,7 @@ struct fib {
struct aac_hba_map_info { struct aac_hba_map_info {
__le32 rmw_nexus; /* nexus for native HBA devices */ __le32 rmw_nexus; /* nexus for native HBA devices */
u8 devtype; /* device type */ u8 devtype; /* device type */
u8 reset_state; /* 0 - no reset, 1..x - */ s8 reset_state; /* 0 - no reset, 1..x - */
/* after xth TM LUN reset */ /* after xth TM LUN reset */
u16 qd_limit; u16 qd_limit;
u32 scan_counter; u32 scan_counter;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment