Commit ba9b6f9f authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Marc Kleine-Budde

can: peak_pcmcia: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 4a4bfdcd
...@@ -686,8 +686,10 @@ static int __devinit pcan_probe(struct pcmcia_device *pdev) ...@@ -686,8 +686,10 @@ static int __devinit pcan_probe(struct pcmcia_device *pdev)
/* detect available channels */ /* detect available channels */
pcan_add_channels(card); pcan_add_channels(card);
if (!card->chan_count) if (!card->chan_count) {
err = -ENOMEM;
goto probe_err_4; goto probe_err_4;
}
/* init the timer which controls the leds */ /* init the timer which controls the leds */
init_timer(&card->led_timer); init_timer(&card->led_timer);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment