Commit bb084c0f authored by Wolfram Sang's avatar Wolfram Sang Committed by Lee Jones

backlight: pwm_bl: Don't use GPIOF_* with gpiod_get_direction

The documentation was wrong, gpiod_get_direction() returns 0/1 instead
of the GPIOF_* flags. The docs were fixed with commit 94fc7309
("gpio: correct docs about return value of gpiod_get_direction"). Now,
fix this user (until a better, system-wide solution is in place).
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 3157694d
...@@ -321,14 +321,14 @@ static int pwm_backlight_probe(struct platform_device *pdev) ...@@ -321,14 +321,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
/* /*
* If the GPIO is not known to be already configured as output, that * If the GPIO is not known to be already configured as output, that
* is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL, * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
* change the direction to output and set the GPIO as active. * direction to output and set the GPIO as active.
* Do not force the GPIO to active when it was already output as it * Do not force the GPIO to active when it was already output as it
* could cause backlight flickering or we would enable the backlight too * could cause backlight flickering or we would enable the backlight too
* early. Leave the decision of the initial backlight state for later. * early. Leave the decision of the initial backlight state for later.
*/ */
if (pb->enable_gpio && if (pb->enable_gpio &&
gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT) gpiod_get_direction(pb->enable_gpio) != 0)
gpiod_direction_output(pb->enable_gpio, 1); gpiod_direction_output(pb->enable_gpio, 1);
pb->power_supply = devm_regulator_get(&pdev->dev, "power"); pb->power_supply = devm_regulator_get(&pdev->dev, "power");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment