Commit bd0db8c7 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

V4L/DVB: drivers/media/dvb/frontends: remove duplicate structure field initialization

The read_status field is initialized twice to the same value.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)<int(pr[0].line) or int(ps[0].column)<int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 4743319f
...@@ -1833,7 +1833,6 @@ static struct dvb_frontend_ops mb86a16_ops = { ...@@ -1833,7 +1833,6 @@ static struct dvb_frontend_ops mb86a16_ops = {
.get_frontend_algo = mb86a16_frontend_algo, .get_frontend_algo = mb86a16_frontend_algo,
.search = mb86a16_search, .search = mb86a16_search,
.read_status = mb86a16_read_status,
.init = mb86a16_init, .init = mb86a16_init,
.sleep = mb86a16_sleep, .sleep = mb86a16_sleep,
.read_status = mb86a16_read_status, .read_status = mb86a16_read_status,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment