Commit be036bbe authored by Shraddha Barke's avatar Shraddha Barke Committed by Greg Kroah-Hartman

Staging: rdma: ipath: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which
could result from the multiplication of number of elements and size and
it is also a bit nicer to read.
Signed-off-by: default avatarShraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 314fcc0d
...@@ -264,7 +264,7 @@ static int init_chip_first(struct ipath_devdata *dd) ...@@ -264,7 +264,7 @@ static int init_chip_first(struct ipath_devdata *dd)
* Allocate full portcnt array, rather than just cfgports, because * Allocate full portcnt array, rather than just cfgports, because
* cleanup iterates across all possible ports. * cleanup iterates across all possible ports.
*/ */
dd->ipath_pd = kzalloc(sizeof(*dd->ipath_pd) * dd->ipath_portcnt, dd->ipath_pd = kcalloc(dd->ipath_portcnt, sizeof(*dd->ipath_pd),
GFP_KERNEL); GFP_KERNEL);
if (!dd->ipath_pd) { if (!dd->ipath_pd) {
......
...@@ -1027,7 +1027,7 @@ int ipath_init_qp_table(struct ipath_ibdev *idev, int size) ...@@ -1027,7 +1027,7 @@ int ipath_init_qp_table(struct ipath_ibdev *idev, int size)
idev->qp_table.last = 1; /* QPN 0 and 1 are special. */ idev->qp_table.last = 1; /* QPN 0 and 1 are special. */
idev->qp_table.max = size; idev->qp_table.max = size;
idev->qp_table.nmaps = 1; idev->qp_table.nmaps = 1;
idev->qp_table.table = kzalloc(size * sizeof(*idev->qp_table.table), idev->qp_table.table = kcalloc(size, sizeof(*idev->qp_table.table),
GFP_KERNEL); GFP_KERNEL);
if (idev->qp_table.table == NULL) { if (idev->qp_table.table == NULL) {
ret = -ENOMEM; ret = -ENOMEM;
......
...@@ -2059,7 +2059,7 @@ int ipath_register_ib_device(struct ipath_devdata *dd) ...@@ -2059,7 +2059,7 @@ int ipath_register_ib_device(struct ipath_devdata *dd)
* the LKEY). The remaining bits act as a generation number or tag. * the LKEY). The remaining bits act as a generation number or tag.
*/ */
idev->lk_table.max = 1 << ib_ipath_lkey_table_size; idev->lk_table.max = 1 << ib_ipath_lkey_table_size;
idev->lk_table.table = kzalloc(idev->lk_table.max * idev->lk_table.table = kcalloc(idev->lk_table.max,
sizeof(*idev->lk_table.table), sizeof(*idev->lk_table.table),
GFP_KERNEL); GFP_KERNEL);
if (idev->lk_table.table == NULL) { if (idev->lk_table.table == NULL) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment