Commit be7fcf1d authored by Dan Carpenter's avatar Dan Carpenter Committed by Paolo Bonzini

KVM: selftests: Fix a condition in test_hv_cpuid()

The code is trying to check that all the padding is zeroed out and it
does this:

    entry->padding[0] == entry->padding[1] == entry->padding[2] == 0

Assume everything is zeroed correctly, then the first comparison is
true, the next comparison is false and false is equal to zero so the
overall condition is true.  This bug doesn't affect run time very
badly, but the code should instead just check that all three paddings
are zero individually.

Also the error message was copy and pasted from an earlier error and it
wasn't correct.

Fixes: 7edcb734 ("KVM: selftests: Add hyperv_cpuid test")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 2eb06c30
...@@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries, ...@@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
TEST_ASSERT(entry->flags == 0, TEST_ASSERT(entry->flags == 0,
".flags field should be zero"); ".flags field should be zero");
TEST_ASSERT(entry->padding[0] == entry->padding[1] TEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&
== entry->padding[2] == 0, !entry->padding[2], "padding should be zero");
".index field should be zero");
/* /*
* If needed for debug: * If needed for debug:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment