Commit beca62c4 authored by Jason Yan's avatar Jason Yan Committed by Greg Kroah-Hartman

tty: mxser: make mxser_change_speed() return void

No other functions use the return value of mxser_change_speed() and the
return value is always 0 now. Make it return void. This fixes the
following coccicheck warning:

drivers/tty/mxser.c:645:5-8: Unneeded variable: "ret". Return "0" on
line 650
Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Link: https://lore.kernel.org/r/20200506061735.19369-1-yanaijie@huawei.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7b668c06
...@@ -638,16 +638,15 @@ static int mxser_set_baud(struct tty_struct *tty, long newspd) ...@@ -638,16 +638,15 @@ static int mxser_set_baud(struct tty_struct *tty, long newspd)
* This routine is called to set the UART divisor registers to match * This routine is called to set the UART divisor registers to match
* the specified baud rate for a serial port. * the specified baud rate for a serial port.
*/ */
static int mxser_change_speed(struct tty_struct *tty) static void mxser_change_speed(struct tty_struct *tty)
{ {
struct mxser_port *info = tty->driver_data; struct mxser_port *info = tty->driver_data;
unsigned cflag, cval, fcr; unsigned cflag, cval, fcr;
int ret = 0;
unsigned char status; unsigned char status;
cflag = tty->termios.c_cflag; cflag = tty->termios.c_cflag;
if (!info->ioaddr) if (!info->ioaddr)
return ret; return;
if (mxser_set_baud_method[tty->index] == 0) if (mxser_set_baud_method[tty->index] == 0)
mxser_set_baud(tty, tty_get_baud_rate(tty)); mxser_set_baud(tty, tty_get_baud_rate(tty));
...@@ -803,8 +802,6 @@ static int mxser_change_speed(struct tty_struct *tty) ...@@ -803,8 +802,6 @@ static int mxser_change_speed(struct tty_struct *tty)
outb(fcr, info->ioaddr + UART_FCR); /* set fcr */ outb(fcr, info->ioaddr + UART_FCR); /* set fcr */
outb(cval, info->ioaddr + UART_LCR); outb(cval, info->ioaddr + UART_LCR);
return ret;
} }
static void mxser_check_modem_status(struct tty_struct *tty, static void mxser_check_modem_status(struct tty_struct *tty,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment