Commit bfddcaff authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown

ASoC: xtensa: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20191210142614.19405-17-tiwai@suse.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 52f0ac15
...@@ -390,7 +390,6 @@ static int xtfpga_pcm_hw_params(struct snd_soc_component *component, ...@@ -390,7 +390,6 @@ static int xtfpga_pcm_hw_params(struct snd_soc_component *component,
struct snd_pcm_substream *substream, struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *hw_params) struct snd_pcm_hw_params *hw_params)
{ {
int ret;
struct snd_pcm_runtime *runtime = substream->runtime; struct snd_pcm_runtime *runtime = substream->runtime;
struct xtfpga_i2s *i2s = runtime->private_data; struct xtfpga_i2s *i2s = runtime->private_data;
unsigned channels = params_channels(hw_params); unsigned channels = params_channels(hw_params);
...@@ -422,9 +421,7 @@ static int xtfpga_pcm_hw_params(struct snd_soc_component *component, ...@@ -422,9 +421,7 @@ static int xtfpga_pcm_hw_params(struct snd_soc_component *component,
return -EINVAL; return -EINVAL;
} }
ret = snd_pcm_lib_malloc_pages(substream, return 0;
params_buffer_bytes(hw_params));
return ret;
} }
static int xtfpga_pcm_trigger(struct snd_soc_component *component, static int xtfpga_pcm_trigger(struct snd_soc_component *component,
...@@ -472,8 +469,8 @@ static int xtfpga_pcm_new(struct snd_soc_component *component, ...@@ -472,8 +469,8 @@ static int xtfpga_pcm_new(struct snd_soc_component *component,
struct snd_card *card = rtd->card->snd_card; struct snd_card *card = rtd->card->snd_card;
size_t size = xtfpga_pcm_hardware.buffer_bytes_max; size_t size = xtfpga_pcm_hardware.buffer_bytes_max;
snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, SNDRV_DMA_TYPE_DEV, snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
card->dev, size, size); card->dev, size, size);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment