Commit c044170f authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Mauro Carvalho Chehab

[media] media: rc: nuvoton: replace usage of spin_lock_irqsave in ISR

Kernel takes care that interrupts from one source are serialized.
So there's no need to use spinlock_irq_save.
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 73d4576d
...@@ -840,11 +840,10 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) ...@@ -840,11 +840,10 @@ static irqreturn_t nvt_cir_isr(int irq, void *data)
{ {
struct nvt_dev *nvt = data; struct nvt_dev *nvt = data;
u8 status, iren; u8 status, iren;
unsigned long flags;
nvt_dbg_verbose("%s firing", __func__); nvt_dbg_verbose("%s firing", __func__);
spin_lock_irqsave(&nvt->lock, flags); spin_lock(&nvt->lock);
/* /*
* Get IR Status register contents. Write 1 to ack/clear * Get IR Status register contents. Write 1 to ack/clear
...@@ -866,7 +865,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) ...@@ -866,7 +865,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data)
* logical device is being disabled. * logical device is being disabled.
*/ */
if (status == 0xff && iren == 0xff) { if (status == 0xff && iren == 0xff) {
spin_unlock_irqrestore(&nvt->lock, flags); spin_unlock(&nvt->lock);
nvt_dbg_verbose("Spurious interrupt detected"); nvt_dbg_verbose("Spurious interrupt detected");
return IRQ_HANDLED; return IRQ_HANDLED;
} }
...@@ -875,7 +874,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) ...@@ -875,7 +874,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data)
* status bit whether the related interrupt source is enabled * status bit whether the related interrupt source is enabled
*/ */
if (!(status & iren)) { if (!(status & iren)) {
spin_unlock_irqrestore(&nvt->lock, flags); spin_unlock(&nvt->lock);
nvt_dbg_verbose("%s exiting, IRSTS 0x0", __func__); nvt_dbg_verbose("%s exiting, IRSTS 0x0", __func__);
return IRQ_NONE; return IRQ_NONE;
} }
...@@ -923,7 +922,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) ...@@ -923,7 +922,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data)
} }
} }
spin_unlock_irqrestore(&nvt->lock, flags); spin_unlock(&nvt->lock);
nvt_dbg_verbose("%s done", __func__); nvt_dbg_verbose("%s done", __func__);
return IRQ_HANDLED; return IRQ_HANDLED;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment