Commit c365dd4d authored by Martin J. Bligh's avatar Martin J. Bligh Committed by Linus Torvalds

[PATCH] Fix kirq_balance up so I can disable it.

At the moment, there are two different switches used, irqbalance_disabled
and no_balance_irq ... each of which switches half the code off. This
patch harmonises them into one (irqbalance_disable), and uses the old
subarch stuff as a default value so that this is auto-disabled on boxes
like NUMA-Q that can't cope with it.

Also renamed no_balance_irq to NO_BALANCE_IRQ as it's really a static
defined number now, not pretending to be a switch variable any more.
Now off by default for NUMA-Q, on by default for others, but can be
disabled with the boot time flag if people desire.
parent 259b8fb4
...@@ -223,7 +223,7 @@ static void set_ioapic_affinity (unsigned int irq, unsigned long mask) ...@@ -223,7 +223,7 @@ static void set_ioapic_affinity (unsigned int irq, unsigned long mask)
extern unsigned long irq_affinity [NR_IRQS]; extern unsigned long irq_affinity [NR_IRQS];
int __cacheline_aligned pending_irq_balance_apicid [NR_IRQS]; int __cacheline_aligned pending_irq_balance_apicid [NR_IRQS];
static int irqbalance_disabled __initdata = 0; static int irqbalance_disabled = NO_BALANCE_IRQ;
static int physical_balance = 0; static int physical_balance = 0;
struct irq_cpu_info { struct irq_cpu_info {
...@@ -492,7 +492,7 @@ static inline void balance_irq (int cpu, int irq) ...@@ -492,7 +492,7 @@ static inline void balance_irq (int cpu, int irq)
unsigned long allowed_mask; unsigned long allowed_mask;
unsigned int new_cpu; unsigned int new_cpu;
if (no_balance_irq) if (irqbalance_disabled)
return; return;
allowed_mask = cpu_online_map & irq_affinity[irq]; allowed_mask = cpu_online_map & irq_affinity[irq];
......
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
((phys_apic) & (~0xf)) ) ((phys_apic) & (~0xf)) )
#endif #endif
#define no_balance_irq (1) #define NO_BALANCE_IRQ (1)
#define esr_disable (1) #define esr_disable (1)
static inline int apic_id_registered(void) static inline int apic_id_registered(void)
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
#define TARGET_CPUS 0x01 #define TARGET_CPUS 0x01
#endif #endif
#define no_balance_irq (0) #define NO_BALANCE_IRQ (0)
#define esr_disable (0) #define esr_disable (0)
#define INT_DELIVERY_MODE dest_LowestPrio #define INT_DELIVERY_MODE dest_LowestPrio
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
#define TARGET_CPUS (0xf) #define TARGET_CPUS (0xf)
#define no_balance_irq (1) #define NO_BALANCE_IRQ (1)
#define esr_disable (1) #define esr_disable (1)
#define INT_DELIVERY_MODE dest_LowestPrio #define INT_DELIVERY_MODE dest_LowestPrio
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
extern int x86_summit; extern int x86_summit;
#define esr_disable (x86_summit ? 1 : 0) #define esr_disable (x86_summit ? 1 : 0)
#define no_balance_irq (0) #define NO_BALANCE_IRQ (0)
#define XAPIC_DEST_CPUS_MASK 0x0Fu #define XAPIC_DEST_CPUS_MASK 0x0Fu
#define XAPIC_DEST_CLUSTER_MASK 0xF0u #define XAPIC_DEST_CLUSTER_MASK 0xF0u
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment