Commit c503269a authored by Sujith's avatar Sujith Committed by John W. Linville

ath9k_htc: Fix module unloading issue

The maximum number of packets in a single buffer in
stream mode is 10. The driver currently uses 8 - which
caused stack corruption, in the absence of any kind
of OOB checking.

Fixing this to the correct value of 10 fixes the module
unload issue.
Signed-off-by: default avatarSujith <Sujith.Manoharan@atheros.com>
Tested-by: default avatarMing Lei <tom.leiming@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 66b10e33
...@@ -324,7 +324,7 @@ static struct ath9k_htc_hif hif_usb = { ...@@ -324,7 +324,7 @@ static struct ath9k_htc_hif hif_usb = {
static void ath9k_hif_usb_rx_stream(struct hif_device_usb *hif_dev, static void ath9k_hif_usb_rx_stream(struct hif_device_usb *hif_dev,
struct sk_buff *skb) struct sk_buff *skb)
{ {
struct sk_buff *nskb, *skb_pool[8]; struct sk_buff *nskb, *skb_pool[MAX_PKT_NUM_IN_TRANSFER];
int index = 0, i = 0, chk_idx, len = skb->len; int index = 0, i = 0, chk_idx, len = skb->len;
int rx_remain_len = 0, rx_pkt_len = 0; int rx_remain_len = 0, rx_pkt_len = 0;
u16 pkt_len, pkt_tag, pool_index = 0; u16 pkt_len, pkt_tag, pool_index = 0;
......
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#define MAX_RX_URB_NUM 8 #define MAX_RX_URB_NUM 8
#define MAX_RX_BUF_SIZE 16384 #define MAX_RX_BUF_SIZE 16384
#define MAX_PKT_NUM_IN_TRANSFER 10
#define MAX_REG_OUT_URB_NUM 1 #define MAX_REG_OUT_URB_NUM 1
#define MAX_REG_OUT_BUF_NUM 8 #define MAX_REG_OUT_BUF_NUM 8
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment