Commit c9b2a3dc authored by Paul Burton's avatar Paul Burton

MIPS: mm: Consolidate drop_mmu_context() has-ASID checks

If an mm does not have an ASID on the local CPU then drop_mmu_context()
is always redundant, since there's no context to "drop". Various callers
of drop_mmu_context() check whether the mm has been allocated an ASID
before making the call. Move that check into drop_mmu_context() and
remove it from callers to simplify them.
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
parent 67741ba3
...@@ -186,7 +186,9 @@ drop_mmu_context(struct mm_struct *mm) ...@@ -186,7 +186,9 @@ drop_mmu_context(struct mm_struct *mm)
local_irq_save(flags); local_irq_save(flags);
cpu = smp_processor_id(); cpu = smp_processor_id();
if (cpumask_test_cpu(cpu, mm_cpumask(mm))) { if (!cpu_context(cpu, mm)) {
/* no-op */
} else if (cpumask_test_cpu(cpu, mm_cpumask(mm))) {
htw_stop(); htw_stop();
get_new_mmu_context(mm); get_new_mmu_context(mm);
write_c0_entryhi(cpu_asid(cpu, mm)); write_c0_entryhi(cpu_asid(cpu, mm));
......
...@@ -697,10 +697,7 @@ static inline void local_r4k_flush_cache_page(void *args) ...@@ -697,10 +697,7 @@ static inline void local_r4k_flush_cache_page(void *args)
} }
if (exec) { if (exec) {
if (vaddr && cpu_has_vtag_icache && mm == current->active_mm) { if (vaddr && cpu_has_vtag_icache && mm == current->active_mm) {
int cpu = smp_processor_id(); drop_mmu_context(mm);
if (cpu_context(cpu, mm) != 0)
drop_mmu_context(mm);
} else } else
vaddr ? r4k_blast_icache_page(addr) : vaddr ? r4k_blast_icache_page(addr) :
r4k_blast_icache_user_page(addr); r4k_blast_icache_user_page(addr);
......
...@@ -69,14 +69,14 @@ void local_flush_tlb_all(void) ...@@ -69,14 +69,14 @@ void local_flush_tlb_all(void)
void local_flush_tlb_mm(struct mm_struct *mm) void local_flush_tlb_mm(struct mm_struct *mm)
{ {
#ifdef DEBUG_TLB
int cpu = smp_processor_id(); int cpu = smp_processor_id();
if (cpu_context(cpu, mm) != 0) { if (cpu_context(cpu, mm) != 0)
#ifdef DEBUG_TLB
printk("[tlbmm<%lu>]", (unsigned long)cpu_context(cpu, mm)); printk("[tlbmm<%lu>]", (unsigned long)cpu_context(cpu, mm));
#endif #endif
drop_mmu_context(mm);
} drop_mmu_context(mm);
} }
void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start, void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start,
......
...@@ -108,16 +108,8 @@ EXPORT_SYMBOL(local_flush_tlb_all); ...@@ -108,16 +108,8 @@ EXPORT_SYMBOL(local_flush_tlb_all);
these entries, we just bump the asid. */ these entries, we just bump the asid. */
void local_flush_tlb_mm(struct mm_struct *mm) void local_flush_tlb_mm(struct mm_struct *mm)
{ {
int cpu;
preempt_disable(); preempt_disable();
drop_mmu_context(mm);
cpu = smp_processor_id();
if (cpu_context(cpu, mm) != 0) {
drop_mmu_context(mm);
}
preempt_enable(); preempt_enable();
} }
......
...@@ -52,10 +52,7 @@ void local_flush_tlb_all(void) ...@@ -52,10 +52,7 @@ void local_flush_tlb_all(void)
void local_flush_tlb_mm(struct mm_struct *mm) void local_flush_tlb_mm(struct mm_struct *mm)
{ {
int cpu = smp_processor_id(); drop_mmu_context(mm);
if (cpu_context(cpu, mm) != 0)
drop_mmu_context(mm);
} }
void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start, void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment