Commit ca2ef0d5 authored by Geliang Tang's avatar Geliang Tang Committed by Greg Kroah-Hartman

USB: iowarrior: use memdup_user

Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2aa3add0
...@@ -368,14 +368,9 @@ static ssize_t iowarrior_write(struct file *file, ...@@ -368,14 +368,9 @@ static ssize_t iowarrior_write(struct file *file,
case USB_DEVICE_ID_CODEMERCS_IOWPV2: case USB_DEVICE_ID_CODEMERCS_IOWPV2:
case USB_DEVICE_ID_CODEMERCS_IOW40: case USB_DEVICE_ID_CODEMERCS_IOW40:
/* IOW24 and IOW40 use a synchronous call */ /* IOW24 and IOW40 use a synchronous call */
buf = kmalloc(count, GFP_KERNEL); buf = memdup_user(user_buffer, count);
if (!buf) { if (IS_ERR(buf)) {
retval = -ENOMEM; retval = PTR_ERR(buf);
goto exit;
}
if (copy_from_user(buf, user_buffer, count)) {
retval = -EFAULT;
kfree(buf);
goto exit; goto exit;
} }
retval = usb_set_report(dev->interface, 2, 0, buf, count); retval = usb_set_report(dev->interface, 2, 0, buf, count);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment