Commit cad064f1 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Greg Kroah-Hartman

devres: handle zero size in devm_kmalloc()

Make devm_kmalloc() behave similarly to non-managed kmalloc(): return
ZERO_SIZE_PTR when requested size is 0. Update devm_kfree() to handle
this case.
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20200629065008.27620-5-brgl@bgdev.plSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67dd0772
...@@ -819,6 +819,9 @@ void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp) ...@@ -819,6 +819,9 @@ void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp)
{ {
struct devres *dr; struct devres *dr;
if (unlikely(!size))
return ZERO_SIZE_PTR;
/* use raw alloc_dr for kmalloc caller tracing */ /* use raw alloc_dr for kmalloc caller tracing */
dr = alloc_dr(devm_kmalloc_release, size, gfp, dev_to_node(dev)); dr = alloc_dr(devm_kmalloc_release, size, gfp, dev_to_node(dev));
if (unlikely(!dr)) if (unlikely(!dr))
...@@ -950,10 +953,10 @@ void devm_kfree(struct device *dev, const void *p) ...@@ -950,10 +953,10 @@ void devm_kfree(struct device *dev, const void *p)
int rc; int rc;
/* /*
* Special case: pointer to a string in .rodata returned by * Special cases: pointer to a string in .rodata returned by
* devm_kstrdup_const(). * devm_kstrdup_const() or NULL/ZERO ptr.
*/ */
if (unlikely(is_kernel_rodata((unsigned long)p))) if (unlikely(is_kernel_rodata((unsigned long)p) || ZERO_OR_NULL_PTR(p)))
return; return;
rc = devres_destroy(dev, devm_kmalloc_release, rc = devres_destroy(dev, devm_kmalloc_release,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment