Commit ce168911 authored by Trond Myklebust's avatar Trond Myklebust

RPCSEC_GSS: Miscellaneous cleanup of auth_gss.c: we're passing something

as a void * when we know perfectly well what it is.  And we're passing
some arguments that we don't actually use.
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@fys.uio.no>
parent 6ab930be
...@@ -830,10 +830,9 @@ gss_validate(struct rpc_task *task, u32 *p) ...@@ -830,10 +830,9 @@ gss_validate(struct rpc_task *task, u32 *p)
static inline int static inline int
gss_wrap_req_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx, gss_wrap_req_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx,
kxdrproc_t encode, void *rqstp, u32 *p, void *obj) kxdrproc_t encode, struct rpc_rqst *rqstp, u32 *p, void *obj)
{ {
struct rpc_rqst *req = (struct rpc_rqst *)rqstp; struct xdr_buf *snd_buf = &rqstp->rq_snd_buf;
struct xdr_buf *snd_buf = &req->rq_snd_buf;
struct xdr_buf integ_buf; struct xdr_buf integ_buf;
u32 *integ_len = NULL; u32 *integ_len = NULL;
struct xdr_netobj mic; struct xdr_netobj mic;
...@@ -844,7 +843,7 @@ gss_wrap_req_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx, ...@@ -844,7 +843,7 @@ gss_wrap_req_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx,
integ_len = p++; integ_len = p++;
offset = (u8 *)p - (u8 *)snd_buf->head[0].iov_base; offset = (u8 *)p - (u8 *)snd_buf->head[0].iov_base;
*p++ = htonl(req->rq_seqno); *p++ = htonl(rqstp->rq_seqno);
status = encode(rqstp, p, obj); status = encode(rqstp, p, obj);
if (status) if (status)
...@@ -919,10 +918,9 @@ gss_wrap_req(struct rpc_task *task, ...@@ -919,10 +918,9 @@ gss_wrap_req(struct rpc_task *task,
static inline int static inline int
gss_unwrap_resp_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx, gss_unwrap_resp_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx,
kxdrproc_t decode, void *rqstp, u32 **p, void *obj) struct rpc_rqst *rqstp, u32 **p)
{ {
struct rpc_rqst *req = (struct rpc_rqst *)rqstp; struct xdr_buf *rcv_buf = &rqstp->rq_rcv_buf;
struct xdr_buf *rcv_buf = &req->rq_rcv_buf;
struct xdr_buf integ_buf; struct xdr_buf integ_buf;
struct xdr_netobj mic; struct xdr_netobj mic;
u32 data_offset, mic_offset; u32 data_offset, mic_offset;
...@@ -937,7 +935,7 @@ gss_unwrap_resp_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx, ...@@ -937,7 +935,7 @@ gss_unwrap_resp_integ(struct rpc_cred *cred, struct gss_cl_ctx *ctx,
mic_offset = integ_len + data_offset; mic_offset = integ_len + data_offset;
if (mic_offset > rcv_buf->len) if (mic_offset > rcv_buf->len)
return status; return status;
if (ntohl(*(*p)++) != req->rq_seqno) if (ntohl(*(*p)++) != rqstp->rq_seqno)
return status; return status;
if (xdr_buf_subsegment(rcv_buf, &integ_buf, data_offset, if (xdr_buf_subsegment(rcv_buf, &integ_buf, data_offset,
...@@ -975,8 +973,7 @@ gss_unwrap_resp(struct rpc_task *task, ...@@ -975,8 +973,7 @@ gss_unwrap_resp(struct rpc_task *task,
case RPC_GSS_SVC_NONE: case RPC_GSS_SVC_NONE:
goto out_decode; goto out_decode;
case RPC_GSS_SVC_INTEGRITY: case RPC_GSS_SVC_INTEGRITY:
status = gss_unwrap_resp_integ(cred, ctx, decode, status = gss_unwrap_resp_integ(cred, ctx, rqstp, &p);
rqstp, &p, obj);
if (status) if (status)
goto out; goto out;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment