Commit ceaaec98 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

net: deinit automatic LIST_HEAD

commit 9b5e383c (net: Introduce
unregister_netdevice_many()) left an active LIST_HEAD() in
rollback_registered(), with possible memory corruption.

Even if device is freed without touching its unreg_list (and therefore
touching the previous memory location holding LISTE_HEAD(single), better
close the bug for good, since its really subtle.

(Same fix for default_device_exit_batch() for completeness)
Reported-by: default avatarMichal Hocko <mhocko@suse.cz>
Tested-by: default avatarMichal Hocko <mhocko@suse.cz>
Reported-by: default avatarEric W. Biderman <ebiderman@xmission.com>
Tested-by: default avatarEric W. Biderman <ebiderman@xmission.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Octavian Purdila <opurdila@ixiacom.com>
CC: stable <stable@kernel.org> [.33+]
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f87e6f47
...@@ -5066,6 +5066,7 @@ static void rollback_registered(struct net_device *dev) ...@@ -5066,6 +5066,7 @@ static void rollback_registered(struct net_device *dev)
list_add(&dev->unreg_list, &single); list_add(&dev->unreg_list, &single);
rollback_registered_many(&single); rollback_registered_many(&single);
list_del(&single);
} }
unsigned long netdev_fix_features(unsigned long features, const char *name) unsigned long netdev_fix_features(unsigned long features, const char *name)
...@@ -6219,6 +6220,7 @@ static void __net_exit default_device_exit_batch(struct list_head *net_list) ...@@ -6219,6 +6220,7 @@ static void __net_exit default_device_exit_batch(struct list_head *net_list)
} }
} }
unregister_netdevice_many(&dev_kill_list); unregister_netdevice_many(&dev_kill_list);
list_del(&dev_kill_list);
rtnl_unlock(); rtnl_unlock();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment