Commit d0bae4a0 authored by JingYi Hou's avatar JingYi Hou Committed by David S. Miller

net: remove duplicate fetch in sock_getsockopt

In sock_getsockopt(), 'optlen' is fetched the first time from userspace.
'len < 0' is then checked. Then in condition 'SO_MEMINFO', 'optlen' is
fetched the second time from userspace.

If change it between two fetches may cause security problems or unexpected
behaivor, and there is no reason to fetch it a second time.

To fix this, we need to remove the second fetch.
Signed-off-by: default avatarJingYi Hou <houjingyi647@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d0f84d08
...@@ -1477,9 +1477,6 @@ int sock_getsockopt(struct socket *sock, int level, int optname, ...@@ -1477,9 +1477,6 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
{ {
u32 meminfo[SK_MEMINFO_VARS]; u32 meminfo[SK_MEMINFO_VARS];
if (get_user(len, optlen))
return -EFAULT;
sk_get_meminfo(sk, meminfo); sk_get_meminfo(sk, meminfo);
len = min_t(unsigned int, len, sizeof(meminfo)); len = min_t(unsigned int, len, sizeof(meminfo));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment