Commit d1645e52 authored by Hidehiro Kawai's avatar Hidehiro Kawai Committed by Linus Torvalds

jbd: abort when failed to log metadata buffers

If we failed to write metadata buffers to the journal space and succeeded
to write the commit record, stale data can be written back to the
filesystem as metadata in the recovery phase.

To avoid this, when we failed to write out metadata buffers, abort the
journal before writing the commit record.
Signed-off-by: default avatarHidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Acked-by: default avatarJan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 60c11d2a
...@@ -762,6 +762,9 @@ void journal_commit_transaction(journal_t *journal) ...@@ -762,6 +762,9 @@ void journal_commit_transaction(journal_t *journal)
/* AKPM: bforget here */ /* AKPM: bforget here */
} }
if (err)
journal_abort(journal, err);
jbd_debug(3, "JBD: commit phase 6\n"); jbd_debug(3, "JBD: commit phase 6\n");
if (journal_write_commit_record(journal, commit_transaction)) if (journal_write_commit_record(journal, commit_transaction))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment