Commit d2cc4dde authored by Joe Perches's avatar Joe Perches Committed by Alex Elder

bdi_register: add __printf verification, fix arg mismatch

__printf is useful to verify format and arguments.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarAlex Elder <elder@inktank.com>
parent 83aff95e
...@@ -842,7 +842,7 @@ static int ceph_register_bdi(struct super_block *sb, ...@@ -842,7 +842,7 @@ static int ceph_register_bdi(struct super_block *sb,
fsc->backing_dev_info.ra_pages = fsc->backing_dev_info.ra_pages =
default_backing_dev_info.ra_pages; default_backing_dev_info.ra_pages;
err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%d", err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%ld",
atomic_long_inc_return(&bdi_seq)); atomic_long_inc_return(&bdi_seq));
if (!err) if (!err)
sb->s_bdi = &fsc->backing_dev_info; sb->s_bdi = &fsc->backing_dev_info;
......
...@@ -114,6 +114,7 @@ struct backing_dev_info { ...@@ -114,6 +114,7 @@ struct backing_dev_info {
int bdi_init(struct backing_dev_info *bdi); int bdi_init(struct backing_dev_info *bdi);
void bdi_destroy(struct backing_dev_info *bdi); void bdi_destroy(struct backing_dev_info *bdi);
__printf(3, 4)
int bdi_register(struct backing_dev_info *bdi, struct device *parent, int bdi_register(struct backing_dev_info *bdi, struct device *parent,
const char *fmt, ...); const char *fmt, ...);
int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev); int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment