Commit d330fca1 authored by Roger He's avatar Roger He Committed by Alex Deucher

drm/ttm: use bit flag to replace allow_reserved_eviction in ttm_operation_ctx

for saving memory and more bit flag can be used in future
Signed-off-by: default avatarRoger He <Hongbo.He@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c02216ac
...@@ -346,8 +346,8 @@ static int amdgpu_cs_bo_validate(struct amdgpu_cs_parser *p, ...@@ -346,8 +346,8 @@ static int amdgpu_cs_bo_validate(struct amdgpu_cs_parser *p,
struct ttm_operation_ctx ctx = { struct ttm_operation_ctx ctx = {
.interruptible = true, .interruptible = true,
.no_wait_gpu = false, .no_wait_gpu = false,
.allow_reserved_eviction = false, .resv = bo->tbo.resv,
.resv = bo->tbo.resv .flags = 0
}; };
uint32_t domain; uint32_t domain;
int r; int r;
......
...@@ -341,8 +341,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, ...@@ -341,8 +341,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct ttm_operation_ctx ctx = { struct ttm_operation_ctx ctx = {
.interruptible = !kernel, .interruptible = !kernel,
.no_wait_gpu = false, .no_wait_gpu = false,
.allow_reserved_eviction = true, .resv = resv,
.resv = resv .flags = TTM_OPT_FLAG_ALLOW_RES_EVICT
}; };
struct amdgpu_bo *bo; struct amdgpu_bo *bo;
enum ttm_bo_type type; enum ttm_bo_type type;
......
...@@ -730,7 +730,8 @@ static bool ttm_bo_evict_swapout_allowable(struct ttm_buffer_object *bo, ...@@ -730,7 +730,8 @@ static bool ttm_bo_evict_swapout_allowable(struct ttm_buffer_object *bo,
*locked = false; *locked = false;
if (bo->resv == ctx->resv) { if (bo->resv == ctx->resv) {
reservation_object_assert_held(bo->resv); reservation_object_assert_held(bo->resv);
if (ctx->allow_reserved_eviction || !list_empty(&bo->ddestroy)) if (ctx->flags & TTM_OPT_FLAG_ALLOW_RES_EVICT
|| !list_empty(&bo->ddestroy))
ret = true; ret = true;
} else { } else {
*locked = reservation_object_trylock(bo->resv); *locked = reservation_object_trylock(bo->resv);
......
...@@ -263,8 +263,8 @@ struct ttm_bo_kmap_obj { ...@@ -263,8 +263,8 @@ struct ttm_bo_kmap_obj {
* *
* @interruptible: Sleep interruptible if sleeping. * @interruptible: Sleep interruptible if sleeping.
* @no_wait_gpu: Return immediately if the GPU is busy. * @no_wait_gpu: Return immediately if the GPU is busy.
* @allow_reserved_eviction: Allow eviction of reserved BOs.
* @resv: Reservation object to allow reserved evictions with. * @resv: Reservation object to allow reserved evictions with.
* @flags: Including the following flags
* *
* Context for TTM operations like changing buffer placement or general memory * Context for TTM operations like changing buffer placement or general memory
* allocation. * allocation.
...@@ -272,11 +272,14 @@ struct ttm_bo_kmap_obj { ...@@ -272,11 +272,14 @@ struct ttm_bo_kmap_obj {
struct ttm_operation_ctx { struct ttm_operation_ctx {
bool interruptible; bool interruptible;
bool no_wait_gpu; bool no_wait_gpu;
bool allow_reserved_eviction;
struct reservation_object *resv; struct reservation_object *resv;
uint64_t bytes_moved; uint64_t bytes_moved;
uint32_t flags;
}; };
/* Allow eviction of reserved BOs */
#define TTM_OPT_FLAG_ALLOW_RES_EVICT 0x1
/** /**
* ttm_bo_reference - reference a struct ttm_buffer_object * ttm_bo_reference - reference a struct ttm_buffer_object
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment