Commit d46e137c authored by Colin Ian King's avatar Colin Ian King Committed by Chris Wilson

drm/i915/selftests: fix null pointer dereference on pointer data

In the case where data fails to be allocated the error exit path is
via label 'out' where data is dereferenced in a for-loop.  Fix this
by exiting via the label 'out_file' instead to avoid the null pointer
dereference.

Addresses-Coverity: ("Dereference after null check")
Fixes: 50d16d44 ("drm/i915/selftests: Exercise context switching in parallel")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20191009100024.23077-1-colin.king@canonical.com
parent 41f0bc49
...@@ -263,7 +263,7 @@ static int live_parallel_switch(void *arg) ...@@ -263,7 +263,7 @@ static int live_parallel_switch(void *arg)
if (!data) { if (!data) {
i915_gem_context_unlock_engines(ctx); i915_gem_context_unlock_engines(ctx);
err = -ENOMEM; err = -ENOMEM;
goto out; goto out_file;
} }
m = 0; /* Use the first context as our template for the engines */ m = 0; /* Use the first context as our template for the engines */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment