Commit d60fc1bb authored by Niranjan Dighe's avatar Niranjan Dighe Committed by Greg Kroah-Hartman

staging: lustre/lnet: Fix wrong typecasting warning generated by sparse

Fix the following warning generated about type casting by sparse

warning: cast removes address space of expression

The current implementation casts the structure pointers with (char *)
without __user annotation and then adds sizeof struct to it, thereby
generating the sparse warning. Fixed this by removing the unnecessary
char pointer type cast.
Signed-off-by: default avatarNiranjan Dighe <niranjan.dighe@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5fd88337
...@@ -1462,10 +1462,8 @@ lstcon_statrpc_readent(int transop, srpc_msg_t *msg, ...@@ -1462,10 +1462,8 @@ lstcon_statrpc_readent(int transop, srpc_msg_t *msg,
return 0; return 0;
sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0]; sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0];
srpc_stat = (srpc_counters_t __user *) srpc_stat = (srpc_counters_t __user *)(sfwk_stat + 1);
((char *)sfwk_stat + sizeof(*sfwk_stat)); lnet_stat = (lnet_counters_t __user *)(srpc_stat + 1);
lnet_stat = (lnet_counters_t __user *)
((char *)srpc_stat + sizeof(*srpc_stat));
if (copy_to_user(sfwk_stat, &rep->str_fw, sizeof(*sfwk_stat)) || if (copy_to_user(sfwk_stat, &rep->str_fw, sizeof(*sfwk_stat)) ||
copy_to_user(srpc_stat, &rep->str_rpc, sizeof(*srpc_stat)) || copy_to_user(srpc_stat, &rep->str_rpc, sizeof(*srpc_stat)) ||
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment