Commit d754f98b authored by Scott Feldman's avatar Scott Feldman Committed by David S. Miller

net: add phys ID compare helper to test if two IDs are the same

Signed-off-by: default avatarScott Feldman <sfeldma@gmail.com>
Acked-by: default avatarJiri Pirko <jiri@resnulli.us>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0c4f691f
...@@ -766,6 +766,13 @@ struct netdev_phys_item_id { ...@@ -766,6 +766,13 @@ struct netdev_phys_item_id {
unsigned char id_len; unsigned char id_len;
}; };
static inline bool netdev_phys_item_id_same(struct netdev_phys_item_id *a,
struct netdev_phys_item_id *b)
{
return a->id_len == b->id_len &&
memcmp(a->id, b->id, a->id_len) == 0;
}
typedef u16 (*select_queue_fallback_t)(struct net_device *dev, typedef u16 (*select_queue_fallback_t)(struct net_device *dev,
struct sk_buff *skb); struct sk_buff *skb);
......
...@@ -910,13 +910,9 @@ static struct net_device *switchdev_get_dev_by_nhs(struct fib_info *fi) ...@@ -910,13 +910,9 @@ static struct net_device *switchdev_get_dev_by_nhs(struct fib_info *fi)
if (switchdev_port_attr_get(dev, &attr)) if (switchdev_port_attr_get(dev, &attr))
return NULL; return NULL;
if (nhsel > 0) { if (nhsel > 0 &&
if (prev_attr.u.ppid.id_len != attr.u.ppid.id_len) !netdev_phys_item_id_same(&prev_attr.u.ppid, &attr.u.ppid))
return NULL; return NULL;
if (memcmp(prev_attr.u.ppid.id, attr.u.ppid.id,
attr.u.ppid.id_len))
return NULL;
}
prev_attr = attr; prev_attr = attr;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment