Commit d7def204 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Bjorn Helgaas

PCI/PME: Make explicitly non-modular

This code is not being built as a module by anyone:

  config PCIE_PME
        def_bool y
        depends on PCIEPORTBUS && PM

Remove traces of modularity so that when reading the driver there is no
doubt it is builtin-only.

Also delete the .remove function, since that doesn't seem to have a
sensible use case.  With "normal" endpoint drivers, we have in the past set
the suppress_bind_attrs bit to make it clear that the use of ".remove" in a
builtin driver was deleted, but here for PCI, it seems overkill to jump
through the pcie_port_service_driver and into the struct device_driver in
order to finally try and do something similar with the bind setting.

Note that for non-modular code, module_init() translates to
device_initcall().
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 61612e6d
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
* for more details. * for more details.
*/ */
#include <linux/module.h>
#include <linux/pci.h> #include <linux/pci.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/errno.h> #include <linux/errno.h>
...@@ -449,17 +448,6 @@ static int pcie_pme_resume(struct pcie_device *srv) ...@@ -449,17 +448,6 @@ static int pcie_pme_resume(struct pcie_device *srv)
return 0; return 0;
} }
/**
* pcie_pme_remove - Prepare PCIe PME service device for removal.
* @srv - PCIe service device to remove.
*/
static void pcie_pme_remove(struct pcie_device *srv)
{
pcie_pme_suspend(srv);
free_irq(srv->irq, srv);
kfree(get_service_data(srv));
}
static struct pcie_port_service_driver pcie_pme_driver = { static struct pcie_port_service_driver pcie_pme_driver = {
.name = "pcie_pme", .name = "pcie_pme",
.port_type = PCI_EXP_TYPE_ROOT_PORT, .port_type = PCI_EXP_TYPE_ROOT_PORT,
...@@ -468,7 +456,6 @@ static struct pcie_port_service_driver pcie_pme_driver = { ...@@ -468,7 +456,6 @@ static struct pcie_port_service_driver pcie_pme_driver = {
.probe = pcie_pme_probe, .probe = pcie_pme_probe,
.suspend = pcie_pme_suspend, .suspend = pcie_pme_suspend,
.resume = pcie_pme_resume, .resume = pcie_pme_resume,
.remove = pcie_pme_remove,
}; };
/** /**
...@@ -478,5 +465,4 @@ static int __init pcie_pme_service_init(void) ...@@ -478,5 +465,4 @@ static int __init pcie_pme_service_init(void)
{ {
return pcie_port_service_register(&pcie_pme_driver); return pcie_port_service_register(&pcie_pme_driver);
} }
device_initcall(pcie_pme_service_init);
module_init(pcie_pme_service_init);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment