Commit d8182804 authored by Richard Alpe's avatar Richard Alpe Committed by David S. Miller

tipc: fix sparse warnings in new nl api

Fix sparse warnings about non-static declaration of static functions
in the new tipc netlink API.
Signed-off-by: default avatarRichard Alpe <richard.alpe@ericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 958d03b0
...@@ -767,7 +767,8 @@ void tipc_bcbearer_sort(struct tipc_node_map *nm_ptr, u32 node, bool action) ...@@ -767,7 +767,8 @@ void tipc_bcbearer_sort(struct tipc_node_map *nm_ptr, u32 node, bool action)
tipc_bclink_unlock(); tipc_bclink_unlock();
} }
int __tipc_nl_add_bc_link_stat(struct sk_buff *skb, struct tipc_stats *stats) static int __tipc_nl_add_bc_link_stat(struct sk_buff *skb,
struct tipc_stats *stats)
{ {
int i; int i;
struct nlattr *nest; struct nlattr *nest;
......
...@@ -647,7 +647,8 @@ void tipc_bearer_stop(void) ...@@ -647,7 +647,8 @@ void tipc_bearer_stop(void)
} }
/* Caller should hold rtnl_lock to protect the bearer */ /* Caller should hold rtnl_lock to protect the bearer */
int __tipc_nl_add_bearer(struct tipc_nl_msg *msg, struct tipc_bearer *bearer) static int __tipc_nl_add_bearer(struct tipc_nl_msg *msg,
struct tipc_bearer *bearer)
{ {
void *hdr; void *hdr;
struct nlattr *attrs; struct nlattr *attrs;
...@@ -905,7 +906,8 @@ int tipc_nl_bearer_set(struct sk_buff *skb, struct genl_info *info) ...@@ -905,7 +906,8 @@ int tipc_nl_bearer_set(struct sk_buff *skb, struct genl_info *info)
return 0; return 0;
} }
int __tipc_nl_add_media(struct tipc_nl_msg *msg, struct tipc_media *media) static int __tipc_nl_add_media(struct tipc_nl_msg *msg,
struct tipc_media *media)
{ {
void *hdr; void *hdr;
struct nlattr *attrs; struct nlattr *attrs;
......
...@@ -2514,7 +2514,8 @@ int tipc_nl_link_set(struct sk_buff *skb, struct genl_info *info) ...@@ -2514,7 +2514,8 @@ int tipc_nl_link_set(struct sk_buff *skb, struct genl_info *info)
return res; return res;
} }
int __tipc_nl_add_stats(struct sk_buff *skb, struct tipc_stats *s)
static int __tipc_nl_add_stats(struct sk_buff *skb, struct tipc_stats *s)
{ {
int i; int i;
struct nlattr *stats; struct nlattr *stats;
...@@ -2580,7 +2581,7 @@ int __tipc_nl_add_stats(struct sk_buff *skb, struct tipc_stats *s) ...@@ -2580,7 +2581,7 @@ int __tipc_nl_add_stats(struct sk_buff *skb, struct tipc_stats *s)
} }
/* Caller should hold appropriate locks to protect the link */ /* Caller should hold appropriate locks to protect the link */
int __tipc_nl_add_link(struct tipc_nl_msg *msg, struct tipc_link *link) static int __tipc_nl_add_link(struct tipc_nl_msg *msg, struct tipc_link *link)
{ {
int err; int err;
void *hdr; void *hdr;
...@@ -2649,8 +2650,9 @@ int __tipc_nl_add_link(struct tipc_nl_msg *msg, struct tipc_link *link) ...@@ -2649,8 +2650,9 @@ int __tipc_nl_add_link(struct tipc_nl_msg *msg, struct tipc_link *link)
} }
/* Caller should hold node lock */ /* Caller should hold node lock */
int __tipc_nl_add_node_links(struct tipc_nl_msg *msg, struct tipc_node *node, static int __tipc_nl_add_node_links(struct tipc_nl_msg *msg,
u32 *prev_link) struct tipc_node *node,
u32 *prev_link)
{ {
u32 i; u32 i;
int err; int err;
......
...@@ -1002,8 +1002,9 @@ void tipc_nametbl_stop(void) ...@@ -1002,8 +1002,9 @@ void tipc_nametbl_stop(void)
write_unlock_bh(&tipc_nametbl_lock); write_unlock_bh(&tipc_nametbl_lock);
} }
int __tipc_nl_add_nametable_publ(struct tipc_nl_msg *msg, struct name_seq *seq, static int __tipc_nl_add_nametable_publ(struct tipc_nl_msg *msg,
struct sub_seq *sseq, u32 *last_publ) struct name_seq *seq,
struct sub_seq *sseq, u32 *last_publ)
{ {
void *hdr; void *hdr;
struct nlattr *attrs; struct nlattr *attrs;
...@@ -1071,8 +1072,8 @@ int __tipc_nl_add_nametable_publ(struct tipc_nl_msg *msg, struct name_seq *seq, ...@@ -1071,8 +1072,8 @@ int __tipc_nl_add_nametable_publ(struct tipc_nl_msg *msg, struct name_seq *seq,
return -EMSGSIZE; return -EMSGSIZE;
} }
int __tipc_nl_subseq_list(struct tipc_nl_msg *msg, struct name_seq *seq, static int __tipc_nl_subseq_list(struct tipc_nl_msg *msg, struct name_seq *seq,
u32 *last_lower, u32 *last_publ) u32 *last_lower, u32 *last_publ)
{ {
struct sub_seq *sseq; struct sub_seq *sseq;
struct sub_seq *sseq_start; struct sub_seq *sseq_start;
...@@ -1098,8 +1099,8 @@ int __tipc_nl_subseq_list(struct tipc_nl_msg *msg, struct name_seq *seq, ...@@ -1098,8 +1099,8 @@ int __tipc_nl_subseq_list(struct tipc_nl_msg *msg, struct name_seq *seq,
return 0; return 0;
} }
int __tipc_nl_seq_list(struct tipc_nl_msg *msg, u32 *last_type, u32 *last_lower, static int __tipc_nl_seq_list(struct tipc_nl_msg *msg, u32 *last_type,
u32 *last_publ) u32 *last_lower, u32 *last_publ)
{ {
struct hlist_head *seq_head; struct hlist_head *seq_head;
struct name_seq *seq; struct name_seq *seq;
......
...@@ -609,7 +609,7 @@ void tipc_node_unlock(struct tipc_node *node) ...@@ -609,7 +609,7 @@ void tipc_node_unlock(struct tipc_node *node)
} }
/* Caller should hold node lock for the passed node */ /* Caller should hold node lock for the passed node */
int __tipc_nl_add_node(struct tipc_nl_msg *msg, struct tipc_node *node) static int __tipc_nl_add_node(struct tipc_nl_msg *msg, struct tipc_node *node)
{ {
void *hdr; void *hdr;
struct nlattr *attrs; struct nlattr *attrs;
......
...@@ -2811,7 +2811,7 @@ void tipc_socket_stop(void) ...@@ -2811,7 +2811,7 @@ void tipc_socket_stop(void)
} }
/* Caller should hold socket lock for the passed tipc socket. */ /* Caller should hold socket lock for the passed tipc socket. */
int __tipc_nl_add_sk_con(struct sk_buff *skb, struct tipc_sock *tsk) static int __tipc_nl_add_sk_con(struct sk_buff *skb, struct tipc_sock *tsk)
{ {
u32 peer_node; u32 peer_node;
u32 peer_port; u32 peer_port;
...@@ -2846,8 +2846,8 @@ int __tipc_nl_add_sk_con(struct sk_buff *skb, struct tipc_sock *tsk) ...@@ -2846,8 +2846,8 @@ int __tipc_nl_add_sk_con(struct sk_buff *skb, struct tipc_sock *tsk)
} }
/* Caller should hold socket lock for the passed tipc socket. */ /* Caller should hold socket lock for the passed tipc socket. */
int __tipc_nl_add_sk(struct sk_buff *skb, struct netlink_callback *cb, static int __tipc_nl_add_sk(struct sk_buff *skb, struct netlink_callback *cb,
struct tipc_sock *tsk) struct tipc_sock *tsk)
{ {
int err; int err;
void *hdr; void *hdr;
...@@ -2912,8 +2912,9 @@ int tipc_nl_sk_dump(struct sk_buff *skb, struct netlink_callback *cb) ...@@ -2912,8 +2912,9 @@ int tipc_nl_sk_dump(struct sk_buff *skb, struct netlink_callback *cb)
} }
/* Caller should hold socket lock for the passed tipc socket. */ /* Caller should hold socket lock for the passed tipc socket. */
int __tipc_nl_add_sk_publ(struct sk_buff *skb, struct netlink_callback *cb, static int __tipc_nl_add_sk_publ(struct sk_buff *skb,
struct publication *publ) struct netlink_callback *cb,
struct publication *publ)
{ {
void *hdr; void *hdr;
struct nlattr *attrs; struct nlattr *attrs;
...@@ -2950,8 +2951,9 @@ int __tipc_nl_add_sk_publ(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -2950,8 +2951,9 @@ int __tipc_nl_add_sk_publ(struct sk_buff *skb, struct netlink_callback *cb,
} }
/* Caller should hold socket lock for the passed tipc socket. */ /* Caller should hold socket lock for the passed tipc socket. */
int __tipc_nl_list_sk_publ(struct sk_buff *skb, struct netlink_callback *cb, static int __tipc_nl_list_sk_publ(struct sk_buff *skb,
struct tipc_sock *tsk, u32 *last_publ) struct netlink_callback *cb,
struct tipc_sock *tsk, u32 *last_publ)
{ {
int err; int err;
struct publication *p; struct publication *p;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment