Commit d95fe371 authored by Pratik Rajesh Sampat's avatar Pratik Rajesh Sampat Committed by Michael Ellerman

cpufreq: powernv: Fix frame-size-overflow in powernv_cpufreq_work_fn

The patch avoids allocating cpufreq_policy on stack hence fixing frame
size overflow in 'powernv_cpufreq_work_fn'

Fixes: 22794280 ("cpufreq: powernv: Restore cpu frequency to policy->cur on unthrottling")
Signed-off-by: default avatarPratik Rajesh Sampat <psampat@linux.ibm.com>
Reviewed-by: default avatarDaniel Axtens <dja@axtens.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200316135743.57735-1-psampat@linux.ibm.com
parent 850507f3
...@@ -902,6 +902,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = { ...@@ -902,6 +902,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = {
void powernv_cpufreq_work_fn(struct work_struct *work) void powernv_cpufreq_work_fn(struct work_struct *work)
{ {
struct chip *chip = container_of(work, struct chip, throttle); struct chip *chip = container_of(work, struct chip, throttle);
struct cpufreq_policy *policy;
unsigned int cpu; unsigned int cpu;
cpumask_t mask; cpumask_t mask;
...@@ -916,12 +917,14 @@ void powernv_cpufreq_work_fn(struct work_struct *work) ...@@ -916,12 +917,14 @@ void powernv_cpufreq_work_fn(struct work_struct *work)
chip->restore = false; chip->restore = false;
for_each_cpu(cpu, &mask) { for_each_cpu(cpu, &mask) {
int index; int index;
struct cpufreq_policy policy;
cpufreq_get_policy(&policy, cpu); policy = cpufreq_cpu_get(cpu);
index = cpufreq_table_find_index_c(&policy, policy.cur); if (!policy)
powernv_cpufreq_target_index(&policy, index); continue;
cpumask_andnot(&mask, &mask, policy.cpus); index = cpufreq_table_find_index_c(policy, policy->cur);
powernv_cpufreq_target_index(policy, index);
cpumask_andnot(&mask, &mask, policy->cpus);
cpufreq_cpu_put(policy);
} }
out: out:
put_online_cpus(); put_online_cpus();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment