Commit da51d32d authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Ben Myers

xfs: use xfs_ilock_data_map_shared in xfs_qm_dqiterate

We might not have read in the extent list at this point, so make sure we
take the ilock exclusively if we have to do so.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent f4df8adc
...@@ -1222,16 +1222,18 @@ xfs_qm_dqiterate( ...@@ -1222,16 +1222,18 @@ xfs_qm_dqiterate(
lblkno = 0; lblkno = 0;
maxlblkcnt = XFS_B_TO_FSB(mp, mp->m_super->s_maxbytes); maxlblkcnt = XFS_B_TO_FSB(mp, mp->m_super->s_maxbytes);
do { do {
uint lock_mode;
nmaps = XFS_DQITER_MAP_SIZE; nmaps = XFS_DQITER_MAP_SIZE;
/* /*
* We aren't changing the inode itself. Just changing * We aren't changing the inode itself. Just changing
* some of its data. No new blocks are added here, and * some of its data. No new blocks are added here, and
* the inode is never added to the transaction. * the inode is never added to the transaction.
*/ */
xfs_ilock(qip, XFS_ILOCK_SHARED); lock_mode = xfs_ilock_data_map_shared(qip);
error = xfs_bmapi_read(qip, lblkno, maxlblkcnt - lblkno, error = xfs_bmapi_read(qip, lblkno, maxlblkcnt - lblkno,
map, &nmaps, 0); map, &nmaps, 0);
xfs_iunlock(qip, XFS_ILOCK_SHARED); xfs_iunlock(qip, lock_mode);
if (error) if (error)
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment