Commit dbfc189c authored by Julia Lawall's avatar Julia Lawall Committed by Benjamin Herrenschmidt

powerpc/cell/iommu: Add missing of_node_put

np is initialized to the result of calling a function that calls
of_node_get, so of_node_put should be called before the pointer is dropped.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1,e2;
@@

* e = \(of_find_node_by_type\|of_find_node_by_name\)(...)
  ... when != of_node_put(e)
      when != true e == NULL
      when != e2 = e
  e = e1
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 8d3d589a
...@@ -1037,6 +1037,8 @@ static int __init cell_iommu_fixed_mapping_init(void) ...@@ -1037,6 +1037,8 @@ static int __init cell_iommu_fixed_mapping_init(void)
/* The fixed mapping is only supported on axon machines */ /* The fixed mapping is only supported on axon machines */
np = of_find_node_by_name(NULL, "axon"); np = of_find_node_by_name(NULL, "axon");
of_node_put(np);
if (!np) { if (!np) {
pr_debug("iommu: fixed mapping disabled, no axons found\n"); pr_debug("iommu: fixed mapping disabled, no axons found\n");
return -1; return -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment