Commit dc0fafda authored by Bart Van Assche's avatar Bart Van Assche Committed by Nicholas Bellinger

target: Make core_tmr_abort_task() skip TMFs

The loop in core_tmr_abort_task() iterates over sess_cmd_list.
That list is a list of regular commands and task management
functions (TMFs). Skip TMFs in this loop instead of letting
the target drivers filter out TMFs in their get_task_tag()
callback function.

(Drop bogus check removal in tcm_qla2xxx_get_task_tag - nab)
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: <qla2xxx-upstream@qlogic.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 6ae50408
...@@ -125,8 +125,8 @@ void core_tmr_abort_task( ...@@ -125,8 +125,8 @@ void core_tmr_abort_task(
if (dev != se_cmd->se_dev) if (dev != se_cmd->se_dev)
continue; continue;
/* skip se_cmd associated with tmr */ /* skip task management functions, including tmr->task_cmd */
if (tmr->task_cmd == se_cmd) if (se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)
continue; continue;
ref_tag = se_cmd->se_tfo->get_task_tag(se_cmd); ref_tag = se_cmd->se_tfo->get_task_tag(se_cmd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment