Commit dc3eaba4 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

media: v4l: vsp1: Add BRx dynamic assignment debugging messages

Dynamic assignment of the BRU and BRS to pipelines is prone to
regressions, add messages to make debugging easier. Keep it as a
separate commit to ease removal of those messages once the code will
deem to be completely stable.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent f81f9adc
...@@ -190,6 +190,10 @@ static int vsp1_du_pipeline_setup_bru(struct vsp1_device *vsp1, ...@@ -190,6 +190,10 @@ static int vsp1_du_pipeline_setup_bru(struct vsp1_device *vsp1,
/* Release our BRU if we have one. */ /* Release our BRU if we have one. */
if (pipe->bru) { if (pipe->bru) {
dev_dbg(vsp1->dev, "%s: pipe %u: releasing %s\n",
__func__, pipe->lif->index,
BRU_NAME(pipe->bru));
/* /*
* The BRU might be acquired by the other pipeline in * The BRU might be acquired by the other pipeline in
* the next step. We must thus remove it from the list * the next step. We must thus remove it from the list
...@@ -219,6 +223,9 @@ static int vsp1_du_pipeline_setup_bru(struct vsp1_device *vsp1, ...@@ -219,6 +223,9 @@ static int vsp1_du_pipeline_setup_bru(struct vsp1_device *vsp1,
if (bru->pipe) { if (bru->pipe) {
struct vsp1_drm_pipeline *owner_pipe; struct vsp1_drm_pipeline *owner_pipe;
dev_dbg(vsp1->dev, "%s: pipe %u: waiting for %s\n",
__func__, pipe->lif->index, BRU_NAME(bru));
owner_pipe = to_vsp1_drm_pipeline(bru->pipe); owner_pipe = to_vsp1_drm_pipeline(bru->pipe);
owner_pipe->force_bru_release = true; owner_pipe->force_bru_release = true;
...@@ -245,6 +252,9 @@ static int vsp1_du_pipeline_setup_bru(struct vsp1_device *vsp1, ...@@ -245,6 +252,9 @@ static int vsp1_du_pipeline_setup_bru(struct vsp1_device *vsp1,
&pipe->entities); &pipe->entities);
/* Add the BRU to the pipeline. */ /* Add the BRU to the pipeline. */
dev_dbg(vsp1->dev, "%s: pipe %u: acquired %s\n",
__func__, pipe->lif->index, BRU_NAME(bru));
pipe->bru = bru; pipe->bru = bru;
pipe->bru->pipe = pipe; pipe->bru->pipe = pipe;
pipe->bru->sink = &pipe->output->entity; pipe->bru->sink = &pipe->output->entity;
...@@ -548,6 +558,10 @@ int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, ...@@ -548,6 +558,10 @@ int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index,
drm_pipe->du_complete = NULL; drm_pipe->du_complete = NULL;
pipe->num_inputs = 0; pipe->num_inputs = 0;
dev_dbg(vsp1->dev, "%s: pipe %u: releasing %s\n",
__func__, pipe->lif->index,
BRU_NAME(pipe->bru));
list_del(&pipe->bru->list_pipe); list_del(&pipe->bru->list_pipe);
pipe->bru->pipe = NULL; pipe->bru->pipe = NULL;
pipe->bru = NULL; pipe->bru = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment