Commit dd5e0249 authored by Chris Wilson's avatar Chris Wilson Committed by Joonas Lahtinen

drm/i915/selftests: Prevent selecting 0 for our random width/align

When igt_random_offset() is a given a range of [0, PAGE_SIZE], it is
allowed to return 0. However, attempting to use a size of 0 for the
igt_lmem_write_cpu() byte poking, leads to call igt_random_offset() with
a range of [offset, offset + 0] and ask it to find a length of 4 within
it. This triggers the bug on that the requested length should fit within
the range!
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200806145728.16495-1-chris@chris-wilson.co.ukSigned-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
parent e2300560
...@@ -522,9 +522,9 @@ static int igt_lmem_write_cpu(void *arg) ...@@ -522,9 +522,9 @@ static int igt_lmem_write_cpu(void *arg)
goto out_unpin; goto out_unpin;
} }
/* We want to throw in a random width/align */ /* A random multiple of u32, picked between [64, PAGE_SIZE - 64] */
bytes[0] = igt_random_offset(&prng, 0, PAGE_SIZE, sizeof(u32), bytes[0] = igt_random_offset(&prng, 64, PAGE_SIZE - 64, 0, sizeof(u32));
sizeof(u32)); GEM_BUG_ON(!IS_ALIGNED(bytes[0], sizeof(u32)));
i = 0; i = 0;
do { do {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment