Commit dd9e5efe authored by Minchan Kim's avatar Minchan Kim Committed by Linus Torvalds

mm/compaction.c: avoid double mem_cgroup_del_lru()

del_page_from_lru_list() already called mem_cgroup_del_lru().  So we must
not call it again.  It adds unnecessary overhead.

It was not a runtime bug because the TestClearPageCgroupAcctLRU() early in
mem_cgroup_del_lru_list() will prevent any double-deletion, etc.
Signed-off-by: default avatarMinchan Kim <minchan.kim@gmail.com>
Acked-by: default avatarBalbir Singh <balbir@linux.vnet.ibm.com>
Acked-by: default avatarKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: default avatarMel Gorman <mel@csn.ul.ie>
Reviewed-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 90a8a73c
...@@ -279,7 +279,6 @@ static unsigned long isolate_migratepages(struct zone *zone, ...@@ -279,7 +279,6 @@ static unsigned long isolate_migratepages(struct zone *zone,
/* Successfully isolated */ /* Successfully isolated */
del_page_from_lru_list(zone, page, page_lru(page)); del_page_from_lru_list(zone, page, page_lru(page));
list_add(&page->lru, migratelist); list_add(&page->lru, migratelist);
mem_cgroup_del_lru(page);
cc->nr_migratepages++; cc->nr_migratepages++;
/* Avoid isolating too much */ /* Avoid isolating too much */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment