Commit ddf9a003 authored by Ingo Molnar's avatar Ingo Molnar

x86: atomic64: Clean up atomic64_sub_and_test() and atomic64_add_negative()

Linus noticed that the variable name 'old_val' is
confusingly named in these functions - the correct
naming is 'new_val'.
Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
LKML-Reference: <alpine.LFD.2.01.0907030942260.3210@localhost.localdomain>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 3a8d1788
...@@ -175,9 +175,9 @@ EXPORT_SYMBOL(atomic64_sub); ...@@ -175,9 +175,9 @@ EXPORT_SYMBOL(atomic64_sub);
*/ */
int atomic64_sub_and_test(u64 delta, atomic64_t *ptr) int atomic64_sub_and_test(u64 delta, atomic64_t *ptr)
{ {
u64 old_val = atomic64_sub_return(delta, ptr); u64 new_val = atomic64_sub_return(delta, ptr);
return old_val == 0; return new_val == 0;
} }
EXPORT_SYMBOL(atomic64_sub_and_test); EXPORT_SYMBOL(atomic64_sub_and_test);
...@@ -244,8 +244,8 @@ EXPORT_SYMBOL(atomic64_inc_and_test); ...@@ -244,8 +244,8 @@ EXPORT_SYMBOL(atomic64_inc_and_test);
*/ */
int atomic64_add_negative(u64 delta, atomic64_t *ptr) int atomic64_add_negative(u64 delta, atomic64_t *ptr)
{ {
long long old_val = atomic64_add_return(delta, ptr); s64 new_val = atomic64_add_return(delta, ptr);
return old_val < 0; return new_val < 0;
} }
EXPORT_SYMBOL(atomic64_add_negative); EXPORT_SYMBOL(atomic64_add_negative);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment