Commit e01886ad authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds

checkpatch: fix 'return is not a function' square bracket handling

We are incorrectly matching square brackets '[' and ']' leading to false
positives on more complex functions as below:

    return (dt3155_fbuffer[m]->ready_head -
	dt3155_fbuffer[m]->ready_len +
	dt3155_fbuffer[m]->nbuffers)%
	(dt3155_fbuffer[m]->nbuffers);
Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 72f115f9
...@@ -2609,7 +2609,7 @@ sub process { ...@@ -2609,7 +2609,7 @@ sub process {
# Flatten any parentheses # Flatten any parentheses
$value =~ s/\(/ \(/g; $value =~ s/\(/ \(/g;
$value =~ s/\)/\) /g; $value =~ s/\)/\) /g;
while ($value =~ s/\[[^\{\}]*\]/1/ || while ($value =~ s/\[[^\[\]]*\]/1/ ||
$value !~ /(?:$Ident|-?$Constant)\s* $value !~ /(?:$Ident|-?$Constant)\s*
$Compare\s* $Compare\s*
(?:$Ident|-?$Constant)/x && (?:$Ident|-?$Constant)/x &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment