Commit e04e3950 authored by Christophe Leroy's avatar Christophe Leroy Committed by Michael Ellerman

drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap()

_PAGE_NO_CACHE is a platform specific flag. In addition, this flag
is misleading because one would think it requests a noncached page
whereas a noncached page is _PAGE_NO_CACHE | _PAGE_GUARDED

_PAGE_NO_CACHE alone means write combined noncached page, so lets
use ioremap_wc() instead.

_PAGE_WRITETHRU is also platform specific flag. Use ioremap_wt()
instead.
Signed-off-by: default avatarChristophe Leroy <christophe.leroy@c-s.fr>
Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 86c391bd
...@@ -27,7 +27,6 @@ ...@@ -27,7 +27,6 @@
#include <linux/init.h> #include <linux/init.h>
#include <linux/pci.h> #include <linux/pci.h>
#include <linux/console.h> #include <linux/console.h>
#include <asm/io.h>
#ifdef CONFIG_PMAC_BACKLIGHT #ifdef CONFIG_PMAC_BACKLIGHT
#include <asm/backlight.h> #include <asm/backlight.h>
...@@ -401,7 +400,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent) ...@@ -401,7 +400,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
#endif /* CONFIG_PMAC_BACKLIGHT */ #endif /* CONFIG_PMAC_BACKLIGHT */
#ifdef CONFIG_PPC #ifdef CONFIG_PPC
p->screen_base = __ioremap(addr, 0x200000, _PAGE_NO_CACHE); p->screen_base = ioremap_wc(addr, 0x200000);
#else #else
p->screen_base = ioremap(addr, 0x200000); p->screen_base = ioremap(addr, 0x200000);
#endif #endif
......
...@@ -48,9 +48,7 @@ ...@@ -48,9 +48,7 @@
#include <linux/nvram.h> #include <linux/nvram.h>
#include <linux/adb.h> #include <linux/adb.h>
#include <linux/cuda.h> #include <linux/cuda.h>
#include <asm/io.h>
#include <asm/prom.h> #include <asm/prom.h>
#include <asm/pgtable.h>
#include <asm/btext.h> #include <asm/btext.h>
#include "macmodes.h" #include "macmodes.h"
...@@ -715,8 +713,7 @@ static int __init control_of_init(struct device_node *dp) ...@@ -715,8 +713,7 @@ static int __init control_of_init(struct device_node *dp)
goto error_out; goto error_out;
} }
/* map at most 8MB for the frame buffer */ /* map at most 8MB for the frame buffer */
p->frame_buffer = __ioremap(p->frame_buffer_phys, 0x800000, p->frame_buffer = ioremap_wt(p->frame_buffer_phys, 0x800000);
_PAGE_WRITETHRU);
if (!p->control_regs_phys || if (!p->control_regs_phys ||
!request_mem_region(p->control_regs_phys, p->control_regs_size, !request_mem_region(p->control_regs_phys, p->control_regs_size,
......
...@@ -32,9 +32,7 @@ ...@@ -32,9 +32,7 @@
#include <linux/nvram.h> #include <linux/nvram.h>
#include <linux/of_device.h> #include <linux/of_device.h>
#include <linux/of_platform.h> #include <linux/of_platform.h>
#include <asm/io.h>
#include <asm/prom.h> #include <asm/prom.h>
#include <asm/pgtable.h>
#include "macmodes.h" #include "macmodes.h"
#include "platinumfb.h" #include "platinumfb.h"
...@@ -577,8 +575,7 @@ static int platinumfb_probe(struct platform_device* odev) ...@@ -577,8 +575,7 @@ static int platinumfb_probe(struct platform_device* odev)
/* frame buffer - map only 4MB */ /* frame buffer - map only 4MB */
pinfo->frame_buffer_phys = pinfo->rsrc_fb.start; pinfo->frame_buffer_phys = pinfo->rsrc_fb.start;
pinfo->frame_buffer = __ioremap(pinfo->rsrc_fb.start, 0x400000, pinfo->frame_buffer = ioremap_wt(pinfo->rsrc_fb.start, 0x400000);
_PAGE_WRITETHRU);
pinfo->base_frame_buffer = pinfo->frame_buffer; pinfo->base_frame_buffer = pinfo->frame_buffer;
/* registers */ /* registers */
......
...@@ -54,13 +54,11 @@ ...@@ -54,13 +54,11 @@
#include <linux/nvram.h> #include <linux/nvram.h>
#include <linux/adb.h> #include <linux/adb.h>
#include <linux/cuda.h> #include <linux/cuda.h>
#include <asm/io.h>
#ifdef CONFIG_MAC #ifdef CONFIG_MAC
#include <asm/macintosh.h> #include <asm/macintosh.h>
#else #else
#include <asm/prom.h> #include <asm/prom.h>
#endif #endif
#include <asm/pgtable.h>
#include "macmodes.h" #include "macmodes.h"
#include "valkyriefb.h" #include "valkyriefb.h"
...@@ -318,7 +316,7 @@ static void __init valkyrie_choose_mode(struct fb_info_valkyrie *p) ...@@ -318,7 +316,7 @@ static void __init valkyrie_choose_mode(struct fb_info_valkyrie *p)
int __init valkyriefb_init(void) int __init valkyriefb_init(void)
{ {
struct fb_info_valkyrie *p; struct fb_info_valkyrie *p;
unsigned long frame_buffer_phys, cmap_regs_phys, flags; unsigned long frame_buffer_phys, cmap_regs_phys;
int err; int err;
char *option = NULL; char *option = NULL;
...@@ -337,7 +335,6 @@ int __init valkyriefb_init(void) ...@@ -337,7 +335,6 @@ int __init valkyriefb_init(void)
/* Hardcoded addresses... welcome to 68k Macintosh country :-) */ /* Hardcoded addresses... welcome to 68k Macintosh country :-) */
frame_buffer_phys = 0xf9000000; frame_buffer_phys = 0xf9000000;
cmap_regs_phys = 0x50f24000; cmap_regs_phys = 0x50f24000;
flags = IOMAP_NOCACHE_SER; /* IOMAP_WRITETHROUGH?? */
#else /* ppc (!CONFIG_MAC) */ #else /* ppc (!CONFIG_MAC) */
{ {
struct device_node *dp; struct device_node *dp;
...@@ -354,7 +351,6 @@ int __init valkyriefb_init(void) ...@@ -354,7 +351,6 @@ int __init valkyriefb_init(void)
frame_buffer_phys = r.start; frame_buffer_phys = r.start;
cmap_regs_phys = r.start + 0x304000; cmap_regs_phys = r.start + 0x304000;
flags = _PAGE_WRITETHRU;
} }
#endif /* ppc (!CONFIG_MAC) */ #endif /* ppc (!CONFIG_MAC) */
...@@ -369,7 +365,11 @@ int __init valkyriefb_init(void) ...@@ -369,7 +365,11 @@ int __init valkyriefb_init(void)
} }
p->total_vram = 0x100000; p->total_vram = 0x100000;
p->frame_buffer_phys = frame_buffer_phys; p->frame_buffer_phys = frame_buffer_phys;
p->frame_buffer = __ioremap(frame_buffer_phys, p->total_vram, flags); #ifdef CONFIG_MAC
p->frame_buffer = ioremap_nocache(frame_buffer_phys, p->total_vram);
#else
p->frame_buffer = ioremap_wt(frame_buffer_phys, p->total_vram);
#endif
p->cmap_regs_phys = cmap_regs_phys; p->cmap_regs_phys = cmap_regs_phys;
p->cmap_regs = ioremap(p->cmap_regs_phys, 0x1000); p->cmap_regs = ioremap(p->cmap_regs_phys, 0x1000);
p->valkyrie_regs_phys = cmap_regs_phys+0x6000; p->valkyrie_regs_phys = cmap_regs_phys+0x6000;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment