Commit e127fafd authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Dave Chinner

xfs: remove unnecessary parentheses from log redo item recovery functions

Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 722e2517
...@@ -515,13 +515,13 @@ xfs_efi_recover( ...@@ -515,13 +515,13 @@ xfs_efi_recover(
* just toss the EFI. * just toss the EFI.
*/ */
for (i = 0; i < efip->efi_format.efi_nextents; i++) { for (i = 0; i < efip->efi_format.efi_nextents; i++) {
extp = &(efip->efi_format.efi_extents[i]); extp = &efip->efi_format.efi_extents[i];
startblock_fsb = XFS_BB_TO_FSB(mp, startblock_fsb = XFS_BB_TO_FSB(mp,
XFS_FSB_TO_DADDR(mp, extp->ext_start)); XFS_FSB_TO_DADDR(mp, extp->ext_start));
if ((startblock_fsb == 0) || if (startblock_fsb == 0 ||
(extp->ext_len == 0) || extp->ext_len == 0 ||
(startblock_fsb >= mp->m_sb.sb_dblocks) || startblock_fsb >= mp->m_sb.sb_dblocks ||
(extp->ext_len >= mp->m_sb.sb_agblocks)) { extp->ext_len >= mp->m_sb.sb_agblocks) {
/* /*
* This will pull the EFI from the AIL and * This will pull the EFI from the AIL and
* free the memory associated with it. * free the memory associated with it.
...@@ -539,7 +539,7 @@ xfs_efi_recover( ...@@ -539,7 +539,7 @@ xfs_efi_recover(
xfs_rmap_skip_owner_update(&oinfo); xfs_rmap_skip_owner_update(&oinfo);
for (i = 0; i < efip->efi_format.efi_nextents; i++) { for (i = 0; i < efip->efi_format.efi_nextents; i++) {
extp = &(efip->efi_format.efi_extents[i]); extp = &efip->efi_format.efi_extents[i];
error = xfs_trans_free_extent(tp, efdp, extp->ext_start, error = xfs_trans_free_extent(tp, efdp, extp->ext_start,
extp->ext_len, &oinfo); extp->ext_len, &oinfo);
if (error) if (error)
......
...@@ -454,7 +454,7 @@ xfs_rui_recover( ...@@ -454,7 +454,7 @@ xfs_rui_recover(
* just toss the RUI. * just toss the RUI.
*/ */
for (i = 0; i < ruip->rui_format.rui_nextents; i++) { for (i = 0; i < ruip->rui_format.rui_nextents; i++) {
rmap = &(ruip->rui_format.rui_extents[i]); rmap = &ruip->rui_format.rui_extents[i];
startblock_fsb = XFS_BB_TO_FSB(mp, startblock_fsb = XFS_BB_TO_FSB(mp,
XFS_FSB_TO_DADDR(mp, rmap->me_startblock)); XFS_FSB_TO_DADDR(mp, rmap->me_startblock));
switch (rmap->me_flags & XFS_RMAP_EXTENT_TYPE_MASK) { switch (rmap->me_flags & XFS_RMAP_EXTENT_TYPE_MASK) {
...@@ -469,10 +469,10 @@ xfs_rui_recover( ...@@ -469,10 +469,10 @@ xfs_rui_recover(
op_ok = false; op_ok = false;
break; break;
} }
if (!op_ok || (startblock_fsb == 0) || if (!op_ok || startblock_fsb == 0 ||
(rmap->me_len == 0) || rmap->me_len == 0 ||
(startblock_fsb >= mp->m_sb.sb_dblocks) || startblock_fsb >= mp->m_sb.sb_dblocks ||
(rmap->me_len >= mp->m_sb.sb_agblocks) || rmap->me_len >= mp->m_sb.sb_agblocks ||
(rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)) { (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)) {
/* /*
* This will pull the RUI from the AIL and * This will pull the RUI from the AIL and
...@@ -490,7 +490,7 @@ xfs_rui_recover( ...@@ -490,7 +490,7 @@ xfs_rui_recover(
rudp = xfs_trans_get_rud(tp, ruip); rudp = xfs_trans_get_rud(tp, ruip);
for (i = 0; i < ruip->rui_format.rui_nextents; i++) { for (i = 0; i < ruip->rui_format.rui_nextents; i++) {
rmap = &(ruip->rui_format.rui_extents[i]); rmap = &ruip->rui_format.rui_extents[i];
state = (rmap->me_flags & XFS_RMAP_EXTENT_UNWRITTEN) ? state = (rmap->me_flags & XFS_RMAP_EXTENT_UNWRITTEN) ?
XFS_EXT_UNWRITTEN : XFS_EXT_NORM; XFS_EXT_UNWRITTEN : XFS_EXT_NORM;
whichfork = (rmap->me_flags & XFS_RMAP_EXTENT_ATTR_FORK) ? whichfork = (rmap->me_flags & XFS_RMAP_EXTENT_ATTR_FORK) ?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment