Commit e24186e0 authored by Paolo Bonzini's avatar Paolo Bonzini

KVM: emulate: move around some checks

The only purpose of this patch is to make the next patch simpler
to review.  No semantic change.
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 6addfc42
...@@ -4388,12 +4388,15 @@ int x86_decode_insn(struct x86_emulate_ctxt *ctxt, void *insn, int insn_len) ...@@ -4388,12 +4388,15 @@ int x86_decode_insn(struct x86_emulate_ctxt *ctxt, void *insn, int insn_len)
ctxt->d |= opcode.flags; ctxt->d |= opcode.flags;
} }
/* Unrecognised? */
if (ctxt->d == 0)
return EMULATION_FAILED;
ctxt->execute = opcode.u.execute; ctxt->execute = opcode.u.execute;
ctxt->check_perm = opcode.check_perm; ctxt->check_perm = opcode.check_perm;
ctxt->intercept = opcode.intercept; ctxt->intercept = opcode.intercept;
/* Unrecognised? */ if (ctxt->d & NotImpl)
if (ctxt->d == 0 || (ctxt->d & NotImpl))
return EMULATION_FAILED; return EMULATION_FAILED;
if (!(ctxt->d & EmulateOnUD) && ctxt->ud) if (!(ctxt->d & EmulateOnUD) && ctxt->ud)
...@@ -4535,19 +4538,19 @@ int x86_emulate_insn(struct x86_emulate_ctxt *ctxt) ...@@ -4535,19 +4538,19 @@ int x86_emulate_insn(struct x86_emulate_ctxt *ctxt)
ctxt->mem_read.pos = 0; ctxt->mem_read.pos = 0;
if ((ctxt->mode == X86EMUL_MODE_PROT64 && (ctxt->d & No64)) || /* LOCK prefix is allowed only with some instructions */
(ctxt->d & Undefined)) { if (ctxt->lock_prefix && (!(ctxt->d & Lock) || ctxt->dst.type != OP_MEM)) {
rc = emulate_ud(ctxt); rc = emulate_ud(ctxt);
goto done; goto done;
} }
/* LOCK prefix is allowed only with some instructions */ if ((ctxt->d & SrcMask) == SrcMemFAddr && ctxt->src.type != OP_MEM) {
if (ctxt->lock_prefix && (!(ctxt->d & Lock) || ctxt->dst.type != OP_MEM)) {
rc = emulate_ud(ctxt); rc = emulate_ud(ctxt);
goto done; goto done;
} }
if ((ctxt->d & SrcMask) == SrcMemFAddr && ctxt->src.type != OP_MEM) { if ((ctxt->mode == X86EMUL_MODE_PROT64 && (ctxt->d & No64)) ||
(ctxt->d & Undefined)) {
rc = emulate_ud(ctxt); rc = emulate_ud(ctxt);
goto done; goto done;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment