Commit e4c293c9 authored by Ken Cox's avatar Ken Cox Committed by Greg Kroah-Hartman

Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h

vbuschannel_devinfo_to_string() was declared with the devinfo argument
as a pointer to __iomem space.  No callers of this function need the
__iomem space, so I removed that constraint.

Same thing goes for vbuschannel_sanitize_buffer().  It doesn't need to
operate on I/O space.
Signed-off-by: default avatarKen Cox <jkc@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b7801a2e
...@@ -50,12 +50,12 @@ typedef struct _ULTRA_VBUS_DEVICEINFO { ...@@ -50,12 +50,12 @@ typedef struct _ULTRA_VBUS_DEVICEINFO {
* to a buffer at <p>, had it been infinitely big. * to a buffer at <p>, had it been infinitely big.
*/ */
static inline int static inline int
vbuschannel_sanitize_buffer(char *p, int remain, char __iomem *src, int srcmax) vbuschannel_sanitize_buffer(char *p, int remain, char *src, int srcmax)
{ {
int chars = 0; int chars = 0;
int nonprintable_streak = 0; int nonprintable_streak = 0;
while (srcmax > 0) { while (srcmax > 0) {
if ((readb(src) >= ' ') && (readb(src) < 0x7f)) { if ((*src >= ' ') && (*src < 0x7f)) {
if (nonprintable_streak) { if (nonprintable_streak) {
if (remain > 0) { if (remain > 0) {
*p = ' '; *p = ' ';
...@@ -67,7 +67,7 @@ vbuschannel_sanitize_buffer(char *p, int remain, char __iomem *src, int srcmax) ...@@ -67,7 +67,7 @@ vbuschannel_sanitize_buffer(char *p, int remain, char __iomem *src, int srcmax)
nonprintable_streak = 0; nonprintable_streak = 0;
} }
if (remain > 0) { if (remain > 0) {
*p = readb(src); *p = *src;
p++; p++;
remain--; remain--;
chars++; chars++;
...@@ -146,10 +146,10 @@ vbuschannel_itoa(char *p, int remain, int num) ...@@ -146,10 +146,10 @@ vbuschannel_itoa(char *p, int remain, int num)
* Returns the number of bytes written to <p>. * Returns the number of bytes written to <p>.
*/ */
static inline int static inline int
vbuschannel_devinfo_to_string(ULTRA_VBUS_DEVICEINFO __iomem *devinfo, vbuschannel_devinfo_to_string(ULTRA_VBUS_DEVICEINFO *devinfo,
char *p, int remain, int devix) char *p, int remain, int devix)
{ {
char __iomem *psrc; char *psrc;
int nsrc, x, i, pad; int nsrc, x, i, pad;
int chars = 0; int chars = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment