Commit e6649cc6 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

i7300_edac: Properly initialize per-csrow memory size

Due to the current edac-core limits, we cannot represent a per-channel
memory size, for FB-DIMM drivers. So, we need to sum-up all values
for each slot, in order to properly represent the total amount of
memory found by the i7300 driver.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 1aa4a7b6
...@@ -617,7 +617,7 @@ static int decode_mtr(struct i7300_pvt *pvt, ...@@ -617,7 +617,7 @@ static int decode_mtr(struct i7300_pvt *pvt,
int slot, int ch, int branch, int slot, int ch, int branch,
struct i7300_dimm_info *dinfo, struct i7300_dimm_info *dinfo,
struct csrow_info *p_csrow, struct csrow_info *p_csrow,
u32 *last_page) u32 *nr_pages)
{ {
int mtr, ans, addrBits, channel; int mtr, ans, addrBits, channel;
...@@ -649,6 +649,7 @@ static int decode_mtr(struct i7300_pvt *pvt, ...@@ -649,6 +649,7 @@ static int decode_mtr(struct i7300_pvt *pvt,
addrBits -= 3; /* 8 bits per bytes */ addrBits -= 3; /* 8 bits per bytes */
dinfo->megabytes = 1 << addrBits; dinfo->megabytes = 1 << addrBits;
*nr_pages = dinfo->megabytes << 8;
debugf2("\t\tWIDTH: x%d\n", MTR_DRAM_WIDTH(mtr)); debugf2("\t\tWIDTH: x%d\n", MTR_DRAM_WIDTH(mtr));
...@@ -662,12 +663,8 @@ static int decode_mtr(struct i7300_pvt *pvt, ...@@ -662,12 +663,8 @@ static int decode_mtr(struct i7300_pvt *pvt,
debugf2("\t\tSIZE: %d MB\n", dinfo->megabytes); debugf2("\t\tSIZE: %d MB\n", dinfo->megabytes);
p_csrow->grain = 8; p_csrow->grain = 8;
p_csrow->nr_pages = dinfo->megabytes << 8;
p_csrow->mtype = MEM_FB_DDR2; p_csrow->mtype = MEM_FB_DDR2;
p_csrow->csrow_idx = slot; p_csrow->csrow_idx = slot;
p_csrow->first_page = *last_page;
*last_page += p_csrow->nr_pages;
p_csrow->last_page = *last_page;
p_csrow->page_mask = 0; p_csrow->page_mask = 0;
/* /*
...@@ -780,7 +777,7 @@ static int i7300_init_csrows(struct mem_ctl_info *mci) ...@@ -780,7 +777,7 @@ static int i7300_init_csrows(struct mem_ctl_info *mci)
int rc = -ENODEV; int rc = -ENODEV;
int mtr; int mtr;
int ch, branch, slot, channel; int ch, branch, slot, channel;
u32 last_page = 0; u32 last_page = 0, nr_pages;
pvt = mci->pvt_info; pvt = mci->pvt_info;
...@@ -818,11 +815,17 @@ static int i7300_init_csrows(struct mem_ctl_info *mci) ...@@ -818,11 +815,17 @@ static int i7300_init_csrows(struct mem_ctl_info *mci)
p_csrow = &mci->csrows[slot]; p_csrow = &mci->csrows[slot];
mtr = decode_mtr(pvt, slot, ch, branch, mtr = decode_mtr(pvt, slot, ch, branch,
dinfo, p_csrow, &last_page); dinfo, p_csrow, &nr_pages);
/* if no DIMMS on this row, continue */ /* if no DIMMS on this row, continue */
if (!MTR_DIMMS_PRESENT(mtr)) if (!MTR_DIMMS_PRESENT(mtr))
continue; continue;
/* Update per_csrow memory count */
p_csrow->nr_pages += nr_pages;
p_csrow->first_page = last_page;
last_page += nr_pages;
p_csrow->last_page = last_page;
rc = 0; rc = 0;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment