Commit e6a5fdf5 authored by David S. Miller's avatar David S. Miller

[NIU]: Fix write past end of array in niu_pci_probe_sprom().

Noticed by Coverity checker and reported by Adrian Bunk.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65c88466
...@@ -6213,7 +6213,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np) ...@@ -6213,7 +6213,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np)
val = nr64(ESPC_MOD_STR_LEN); val = nr64(ESPC_MOD_STR_LEN);
niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n", niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n",
(unsigned long long) val); (unsigned long long) val);
if (val > 8 * 4) if (val >= 8 * 4)
return -EINVAL; return -EINVAL;
for (i = 0; i < val; i += 4) { for (i = 0; i < val; i += 4) {
...@@ -6229,7 +6229,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np) ...@@ -6229,7 +6229,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np)
val = nr64(ESPC_BD_MOD_STR_LEN); val = nr64(ESPC_BD_MOD_STR_LEN);
niudbg(PROBE, "SPROM: BD_MOD_STR_LEN[%llu]\n", niudbg(PROBE, "SPROM: BD_MOD_STR_LEN[%llu]\n",
(unsigned long long) val); (unsigned long long) val);
if (val > 4 * 4) if (val >= 4 * 4)
return -EINVAL; return -EINVAL;
for (i = 0; i < val; i += 4) { for (i = 0; i < val; i += 4) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment